Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple frames #644

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

TheLastProject
Copy link

Fixes #638

Changes:

  • New "Transfer to badge" screen
  • All transfer buttons now instead add to the "Transfer to badge" screen
  • Transfer button on "Transfer to badge" screen sends all the (up to 8) frames to the badge

Screenshots for the change:
photo_2020-02-04_16-27-57
photo_2020-02-04_16-27-58
photo_2020-02-04_16-27-59
photo_2020-02-04_16-29-05

TODO (will need help with this, @adityastic):

  • Fix text on badges in transfer queue
  • Fix button alignment in transfer queue
  • Automatically switch to Transfer to badge screen when hitting transfer on another screen

@adityastic
Copy link
Collaborator

adityastic commented Feb 6, 2020

@TheLastProject perfect 🤟. I'm busy with an assignment, will look at it tomorrow morning. Thanks a ton for the pr

@adityastic
Copy link
Collaborator

adityastic commented Feb 17, 2020

@TheLastProject great job 👍. I was just thinking of the process, should we send all the transfer to the transfer section or follow some better approach? Currently by this pr, if the person wants to transfer a single text they will be navigated to the transfer fragment and they need to manually get back to add more items to transfer. @iamareebjamal what are your thoughts on the workflow of this feature?

@TheLastProject
Copy link
Author

If you look at the code and TODOs: "Automatically switch to Transfer to badge screen when hitting transfer on another screen" is planned for me. But I couldn't get that to work so I'll need help there.

@adityastic
Copy link
Collaborator

If you look at the code and TODOs: "Automatically switch to Transfer to badge screen when hitting transfer on another screen" is planned for me. But I couldn't get that to work so I'll need help there.

Dont worry, I'll help you out with that. Lets get the workflow correct, then we can get this done

@adityastic
Copy link
Collaborator

@iamareebjamal please let me know your thoughts on this

@adityastic
Copy link
Collaborator

@iamareebjamal any updates? Should we move forward with this approach?

@iamareebjamal
Copy link
Member

You know better about the project, so go ahead

@adityastic
Copy link
Collaborator

@iamareebjamal great. @TheLastProject If you're free, Please let me know. I'll drop a pr to your branch and let's get this working in the upcoming weekend 👍😊

@TheLastProject
Copy link
Author

Sounds good, I'll have time to look at a PR this weekend probably

@TheLastProject
Copy link
Author

Just gonna ping here again.

@FrankyBoy
Copy link

Hello, has anything happened here?

@adityastic
Copy link
Collaborator

Hello, has anything happened here?

Not really. If you want to take it up, feel free to

@FrankyBoy
Copy link

<< has zero idea how anything mobile apps related works :D

@mariobehling
Copy link
Member

@TheLastProject Hi, we are restarting work on this project. Would you like to fix the failing tests of this pull request?

@TheLastProject
Copy link
Author

Well, in 3 years I guess my Android skills probably improved so I may be able to do the tasks without help now but I don't really have the time to finish this currently I'm afraid (still have a big to-do list on my own projects too) so it's probably best if someone else picks this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 8 Storage Places as functionality to the app
5 participants