Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 8 Storage Places as functionality to the app #638

Open
mariobehling opened this issue Jan 30, 2020 · 8 comments · May be fixed by #644
Open

Add 8 Storage Places as functionality to the app #638

mariobehling opened this issue Jan 30, 2020 · 8 comments · May be fixed by #644

Comments

@mariobehling
Copy link
Member

mariobehling commented Jan 30, 2020

The proprietary app of the LED Badges has a storage functionality for 8 types. Please add this functionality to the app.

These 8 Storage places mean the the badge LED art is stored directly on the badge itself.

Compare: https://play.google.com/store/apps/details?id=com.ls.shaheen.ledcard

Screenshot from 2020-01-30 18-16-51

@adityastic
Copy link
Collaborator

@mariobehling we can create beautiful animations with this. Small 8 frame animations

@TheLastProject
Copy link

I've looked at the code a bit and right now it seems to only support setting all the messages at once.

https://github.com/fossasia/badge-magic-android/blob/0148c450a17db91b6792bfcc32fac97787f672a2/android/src/main/java/org/fossasia/badgemagic/util/SendingUtils.kt#L58-L60 takes a single message, but this should be changed to accepting a List<Message>.

The complexity now comes from the UI: how to make a good UI for setting up to 8 different values...

I'm willing to adopt this feature request and try to implement it myself, but it will take me some time to figure everything out.

@adityastic
Copy link
Collaborator

@TheLastProject you're on the right track, let me know if you need anything

@TheLastProject
Copy link

TheLastProject commented Feb 3, 2020

Making nice progress on this:

photo_2020-02-03_21-08-50

TODO:

  • Actually being able to queue items instead of just sending all saved badges
  • Showing text/clipart instead of the badge name

Hoping to be able to make a pull request adding this feature somewhere this week, but no promises obviously.

@TheLastProject TheLastProject linked a pull request Feb 4, 2020 that will close this issue
3 tasks
@apoorva-raj
Copy link

Hey, can I take this issue up?

@TheLastProject
Copy link

I am not a maintainer (they sadly don't seem very active), but I just want to say you're free to use as much or as little code from #644 as you see fit. I will not be offended if my word-in-progress code gets thrown away for a better implementation :)

@adityastic
Copy link
Collaborator

adityastic commented Dec 20, 2021

Hey, can I take this issue up?

Yes, feel free to. Also @TheLastProject had an amazing implementation. I forgot to review your pr xD Sorry about that. It only needed a couple of additions, you can continue where he left off. I will be able to review it this weekend.

@lanrat
Copy link

lanrat commented Oct 26, 2022

Any movement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

6 participants