Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: File encryption support #5678

Open
wants to merge 39 commits into
base: develop
Choose a base branch
from
Open

feat: File encryption support #5678

wants to merge 39 commits into from

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented May 14, 2024 •
edited by jira bot

Proposed changes

  • iOS encrypt/decrypt poc
  • Android encrypt/decrypt poc
  • iOS receive encrypted from web and decrypt and vice-versa
  • Android receive encrypted from web and decrypt and vice-versa
  • Remove temp files
  • Remove need for -new?
  • Send multiple encrypted attachments at the same time
  • Other file types
  • Fetch blob or feat: remove rn-fetch-blob #5669?
  • Check if file name is properly decrypted
  • Fix upload progress and retry
  • Fix multiple decryptions race fails
  • Check other features on feat(E2EEncryption): File encryption support Rocket.Chat#32316

Issue(s)

Depends on RocketChat/Rocket.Chat#32316

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

E2EE2-7

@diegolmello
Merge branch 'develop' into feat.encrypt-file
f38303d 
# Conflicts:
#	app/lib/encryption/encryption.ts
#	app/lib/encryption/room.ts
#	app/lib/methods/sendFileMessage/sendFileMessage.ts
#	app/views/ShareView/index.tsx
@diegolmello
Minor resolve conflict fixes
945decd
@diegolmello
Stash Android isTrusted file issue
63c0804
@diegolmello
Merge branch 'develop' into feat.encrypt-file
f73421e 
# Conflicts:
#	ios/RocketChatRN.xcodeproj/project.pbxproj
@diegolmello
Starting to use expo-fs on Android
6d8d874
@diegolmello
Refactor file upload
8caf73c
@diegolmello
file upload working on Android and iOS with backwards compatibility :)
761d26c
@diegolmello diegolmello changed the title feat: File encryption support POC feat: File encryption support May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@diegolmello