Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes sending files to start a thread #5670

Merged
merged 3 commits into from
May 20, 2024

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Apr 30, 2024

Proposed changes

Currently, when trying to start a thread with an image or file, it was sent to the room and not to the thread. Another error was that as there was no thread created, the header said that the file would be sent to the room and not to the thread.
This PR fixes both of these errors.

Issue(s)

How to test or reproduce

  • Send a message in the room and click the "Reply in thread" button.
  • Within the "thread" try sending a image.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: CORE-411

@GleidsonDaniel GleidsonDaniel merged commit 0ffa528 into develop May 20, 2024
3 of 8 checks passed
@GleidsonDaniel GleidsonDaniel deleted the sent-image-on-thread branch May 20, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants