Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent sending empty messages #5657

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Prevent sending empty messages #5657

wants to merge 4 commits into from

Conversation

anirbanpaulcom
Copy link

@anirbanpaulcom anirbanpaulcom commented Apr 16, 2024 •
edited

Proposed changes

This PR prevents sending empty or whitespace-only messages by trimming the message content before send

Issue(s)

WhatsApp.Video.2024-04-16.at.6.06.50.PM.mp4

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@anirbanpaulcom
Copy link
Author

@diegolmello , @GleidsonDaniel Please take a look. Thank you!

diegolmello
diegolmello requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey. Thanks for your contribution! Can you write tests on MessageComposer.test.tsx?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegolmello diegolmello Awaiting requested review from diegolmello

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anirbanpaulcom @diegolmello