Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add checks to draft auto save #5639

Merged
merged 8 commits into from
Apr 26, 2024
Merged

Conversation

GleidsonDaniel
Copy link
Contributor

@GleidsonDaniel GleidsonDaniel commented Mar 27, 2024

Proposed changes

Currently the draft was being saved in ShareView and also when the user didn't edit anything they sent a message and clicked back.
This PR fixes the above errors.

Issue(s)

How to test or reproduce

  • With the app closed, type some text in shareExtension, wait 3 seconds, send the message, and return to the app, the text should not appear.
  • With a saved draft, enter a room send the message that was saved in draft without clicking on the input component, send the message and quickly click return to leave the room, the draft must be empty.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

Jira: CORE-222

@GleidsonDaniel GleidsonDaniel merged commit e98ce32 into develop Apr 26, 2024
4 of 9 checks passed
@GleidsonDaniel GleidsonDaniel deleted the fix-auto-save-draft branch April 26, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants