Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: convert E2E tests from Detox to Maestro #5638

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jsathu07
Copy link
Contributor

@jsathu07 jsathu07 commented Mar 27, 2024

Proposed changes

Detox tests are flaky and consumes a lot of resources. Also, developers have to deal with native building errors. This PR converts existing E2E tests to Maestro

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@jsathu07
Copy link
Contributor Author

@diegolmello should I continue with converting tests?

@diegolmello
Copy link
Member

@jsathu07 if you're having progress, yes please. This is something we'll need soon, but we don't have enough hands to work on it.
What's the current state?

@jsathu07
Copy link
Contributor Author

I can work on it but my proposal was rejected @diegolmello

@diegolmello
Copy link
Member

@jsathu07 We can't accept all GSoC projects. We had to choose. I'm sorry.

@jsathu07
Copy link
Contributor Author

@diegolmello Is it due to my low contributions?

@jsathu07
Copy link
Contributor Author

@diegolmello Why was my proposal rejected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants