Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disallow users from sending unencrypted messages in E2EE rooms #5600

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Mar 1, 2024

Proposed changes

  • If user session e2ee is disabled, but the room is encrypted, ask for e2ee password.
  • If e2ee is enabled, but the user's subscription is missing room e2ee key, warns the user to wait until there's an online user to send them the room key.
  • Toasts warning about e2ee enabled/disabled on enter e2ee password view
  • When room is in one of the warnings, add disable encryption to the header

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

E2EE-5

@diegolmello diegolmello marked this pull request as ready for review March 7, 2024 18:07
diegolmello and others added 9 commits April 19, 2024 13:29
# Conflicts:
#	__tests__/containers/RoomHeader/__snapshots__/RoomHeader.stories.storyshot
#	app/i18n/locales/ar.json
#	app/i18n/locales/bn-IN.json
#	app/i18n/locales/de.json
#	app/i18n/locales/en.json
#	app/i18n/locales/fi.json
#	app/i18n/locales/fr.json
#	app/i18n/locales/hi-IN.json
#	app/i18n/locales/hu.json
#	app/i18n/locales/it.json
#	app/i18n/locales/ja.json
#	app/i18n/locales/nl.json
#	app/i18n/locales/pt-BR.json
#	app/i18n/locales/pt-PT.json
#	app/i18n/locales/ru.json
#	app/i18n/locales/sl-SI.json
#	app/i18n/locales/sv.json
#	app/i18n/locales/ta-IN.json
#	app/i18n/locales/te-IN.json
#	app/i18n/locales/tr.json
#	app/i18n/locales/zh-CN.json
#	app/i18n/locales/zh-TW.json
#	app/views/E2EEnterYourPasswordView.tsx
#	app/views/RoomView/index.tsx
# Conflicts:
#	app/lib/encryption/encryption.ts
@diegolmello diegolmello force-pushed the feat.block-room-content-e2ee branch from 4a74684 to 0bea843 Compare May 9, 2024 17:17
@diegolmello diegolmello force-pushed the feat.block-room-content-e2ee branch from d74c574 to b7ace4c Compare May 14, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants