Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Encrypt file descriptions on E2EE rooms #5599

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Feb 29, 2024

Proposed changes

Self explanatory. Added some functions in order to encrypt description on sendFileMessage

Issue(s)

Related to #31840

How to test or reproduce

Note: Depends on #31840, so make sure to test running that branch.

Encrypt

  • Send a file with a description
  • It should be encrypted

Decrypt

  • Send a file with a description on web
  • Mobile should decrypt it

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

CORE-105

@diegolmello diegolmello marked this pull request as ready for review February 29, 2024 13:55
# Conflicts:
#	app/views/ShareView/index.tsx
@diegolmello diegolmello merged commit 94845cb into develop Apr 19, 2024
4 of 9 checks passed
@diegolmello diegolmello deleted the feat.encrypt-file-descriptions branch April 19, 2024 20:19
diegolmello added a commit that referenced this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants