regression: validate that the login error value is actually a string (#…

…5602)
RocketChat · Mar 6, 2024 · 2c0cfa1 · 2c0cfa1
1 parent 2f4bde7
commit 2c0cfa1
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/app/views/LoginView/handleLoginErrors.ts b/app/views/LoginView/handleLoginErrors.ts
@@ -26,10 +26,12 @@ const LOGIN_SUBMIT_ERRORS = {
 };
 
 export const handleLoginErrors = (error: keyof typeof LOGIN_SUBMIT_ERRORS): string => {
-	const errorKey = Object.keys(LOGIN_SUBMIT_ERRORS).find(key => error.includes(key)) as keyof typeof LOGIN_SUBMIT_ERRORS;
-	const e = errorKey ? LOGIN_SUBMIT_ERRORS[errorKey].i18n : 'Login_error';
-	if (i18n.isTranslated(e)) {
-		return i18n.t(e);
+	if (typeof error === 'string') {
+		const errorKey = Object.keys(LOGIN_SUBMIT_ERRORS).find(key => error?.includes(key)) as keyof typeof LOGIN_SUBMIT_ERRORS;
+		const e = errorKey ? LOGIN_SUBMIT_ERRORS[errorKey]?.i18n : 'Login_error';
+		if (i18n.isTranslated(e)) {
+			return i18n.t(e);
+		}
 	}
 	return i18n.t('Login_error');
 };