Better performance by adding layers and caching #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better performance by adding layers and caching. One layer for whole clock and hour hand, the second layer for minute and second hand. All that as virtual canvas then painted to dom canvas. Also added: - periodical config reload every 60s instead of re-reading config every time clock is repainted (+ added TODO comment if it can be known if config changed). - nice console.log that Analog Config has been loaded akin to other HACS, however I haven't added version (would be nice to add it) - print any caught exception to console.error (as an addition to just displaying that on canvas) This change improves performance of HA dashboards displayed on older tablets/smartphones (on the wave of 'don't throw away old electronics, re-use them for something useful' :) ). Disclaimer - checked, it improves performance, probably it could be done better, like even more layers etc.
|
Nice one, I will take a look eventually. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better performance by adding layers and caching. One layer for whole clock and hour hand, the second layer for minute and second hand. All that as virtual canvas then painted to dom canvas.
Also added:
This change improves performance of HA dashboards displayed on older tablets/smartphones (on the wave of 'don't throw away old electronics, re-use them for something useful' :) ).
Disclaimer - checked, it improves performance, probably it could be done better, like even more layers etc.