Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check type of state in ObservableRecyclerView#onRestoreInstanceState(Parcelable) #258

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yshrsmz
Copy link

@yshrsmz yshrsmz commented Jul 20, 2016

fix #254

I'm not 100% sure if this is a right way, but recent version of support RecyclerView is doing this check, so I think it is reasonable to do same in this library

@coveralls
Copy link

coveralls commented Jul 20, 2016

Coverage Status

Coverage decreased (-0.06%) to 93.308% when pulling 7d2734e on yshrsmz:fix-classcastexception into 47a5fb2 on ksoichiro:master.

@yshrsmz
Copy link
Author

yshrsmz commented Jul 20, 2016

for those who want this fix right now, you can use my repo via jitpack as a temporary workaround.

repositories {
  maven { url "https://jitpack.io" }
}
dependencies {
  compile 'com.github.yshrsmz:Android-ObservableScrollView:d5178a3e6b'
}

this also includes all merged fixes from v1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassCastException
2 participants