Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mihomo 1.18.5 (new formula) #172091

Merged
merged 2 commits into from
May 19, 2024
Merged

mihomo 1.18.5 (new formula) #172091

merged 2 commits into from
May 19, 2024

Conversation

guodong000
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels May 19, 2024
carlocab
carlocab reviewed May 19, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; a few suggestions.

Formula/m/mihomo.rb Outdated Show resolved Hide resolved
Formula/m/mihomo.rb Outdated Show resolved Hide resolved
carlocab
carlocab reviewed May 19, 2024
View reviewed changes
Formula/m/mihomo.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label May 19, 2024
@guodong000 guodong000 requested a review from carlocab May 19, 2024 07:19
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label May 19, 2024
carlocab
carlocab approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@carlocab carlocab added the ready to merge PR can be merged once CI is green label May 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

:shipit: @chenrui333 has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label May 19, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue May 19, 2024
Merged via the queue into Homebrew:master with commit f0671e1 May 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@guodong000 @chenrui333 @carlocab @BrewTestBot