fix: fix the type of the argument of KeyedMutator for populateCache
#2933
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Key5n
commented
Apr 8, 2024
Comment on lines
+431
to
+435
| <Data = any, MutationData = Data>( | ||
| key: Arguments, | ||
| data?: T | Promise<T> | MutatorCallback<T>, | ||
| opts?: boolean | MutatorOptions<Data, T> | ||
| ): Promise<T | undefined> | ||
| data?: MutationData | Promise<MutationData> | MutatorCallback<MutationData>, | ||
| opts?: boolean | MutatorOptions<Data, MutationData> | ||
| ): Promise<MutationData | undefined> |
There was a problem hiding this comment.
This is just refactoring for name consistency.
Since there is @typeParam MutationData comment docs, I think the generics parameter T should follow that.
huozhi
reviewed
Jun 1, 2024
|
Sure! If you want to modify my PR, please do at your mercy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes a type error problem related to
populateCacheand boundmutate.Now, the first argument of bound
mutateonly accepts the type of the returned value offetcherbyuseSWR.But in order to make use of
populateCache, the first argument ofmutateshould accept any type of API fetching result.So I changed the type of the first argument from
Data(which is the type of datauseSWRfetches) intoMutationData(which is the type of the data returned by the mutator)In addition, I changed types in
infinitesince it had error when I changed the type ofKeyedMutator.