Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃寪 Update Japanese translation of docs/ja/docs/index.md #11583

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ukwhatn
Copy link

@ukwhatn ukwhatn commented May 16, 2024

Updated the Japanese landing page to match the latest English version.

Specifically, the following sections have been updated:

@tiangolo
Copy link
Owner

馃摑 Docs preview for commit 96d16d0 at: https://15bc434c.fastapitiangolo.pages.dev

@ukwhatn
Copy link
Author

ukwhatn commented May 16, 2024

I forgot to change the line to highlight, fixed.

@tiangolo
Copy link
Owner

馃摑 Docs preview for commit 6ae4a19 at: https://26b3d500.fastapitiangolo.pages.dev

@tiangolo
Copy link
Owner

馃摑 Docs preview for commit eaae5a3 at: https://b9c5ddcc.fastapitiangolo.pages.dev

@alejsdev alejsdev added lang-all Translations lang-ja Japanese translations awaiting-review labels May 16, 2024
@urushio
Copy link
Contributor

urushio commented May 18, 2024

It seems to me to be an appropriate translation. However, I am concerned about the sections where the list items that should be indented are not indented. (Although they appear to be indented in Markdown)
https://b9c5ddcc.fastapitiangolo.pages.dev/ja/#_9

@ukwhatn
Copy link
Author

ukwhatn commented May 18, 2024

@urushio

I am concerned about the sections where the list items that should be indented are not indented. (Although they appear to be indented in Markdown) https://b9c5ddcc.fastapitiangolo.pages.dev/ja/#_9

This "Recap" section seems to be in the same position in the EN version.
If it is not about this section, it would be appreciated if you could give more details.

image image

@urushio
Copy link
Contributor

urushio commented May 18, 2024

@ukwhatn
Sorry for the lack of explanation. Attached are screenshots.
image1
image2

@ukwhatn
Copy link
Author

ukwhatn commented May 18, 2024

@urushio
I see, understand! Thanks for your reply 馃檹

Similar issues have occurred in past PRs (e.g., #11476 ), so it might be an error specific to the preview environment.

https://67d8c39a.fastapitiangolo.pages.dev/ja/#_9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-ja Japanese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants