Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃敤 Specify email-validator dependency with dash #11515

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jirikuncar
Copy link

The package name is email-validator.


This is more of a consistency improvement. I noticed after updating to the latest release that transitive dependencies have been renamed.

@jirikuncar jirikuncar changed the title build: use email-validator with dash build: use email-validator with dash May 2, 2024
@jirikuncar jirikuncar changed the title build: use email-validator with dash 馃敤 Specify email-validator dependency with dash May 2, 2024
@tiangolo
Copy link
Owner

tiangolo commented May 2, 2024

馃摑 Docs preview for commit 6e867de at: https://8841bcea.fastapitiangolo.pages.dev

@jirikuncar
Copy link
Author

jirikuncar commented May 2, 2024

It seems that after deeper investigation, the metadata for the email-validator package defines the name as email_validator - https://github.com/JoshData/python-email-validator/blob/main/setup.cfg#L2. I will move the question there instead. There is an open issue already JoshData/python-email-validator#138.

@jirikuncar jirikuncar marked this pull request as draft May 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants