Add Mintlify icon #10943
Open
Add Mintlify icon #10943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple-icons
bot
added
the
new icon
uncenter
requested changes
May 13, 2024
_data/simple-icons.json
Outdated
| } | ||
| }, | ||
| { | ||
| "title": "Mintlify", | ||
| "hex": "18e299", |
There was a problem hiding this comment.
Suggested change
| "hex": "18e299", | |
| "hex": "18E299", |
_data/simple-icons.json
Outdated
| { | ||
| "title": "Mintlify", | ||
| "hex": "18e299", | ||
| "source": "https://github.com/simple-icons/simple-icons/blob/develop/icons/mintlify.svg" |
There was a problem hiding this comment.
You can't link to our own repository for the source 😅
There was a problem hiding this comment.
I concur - you can use the homepage of the site as your source, as there's an SVG version of the icon there.
|
I've fixed the issues with the data JSON, @deevee47 - can you please make sure you are either using our prettier / eslint config, or disable your format-on-save functionality in your editor to prevent that happening again? |
|
It would also be nice if you could add a preview image of the icon using https://wasm.simpleicons.org/preview, as suggested in the comment of the pull request template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: closes #10934
Popularity metric:
Checklist
_data/simple-icons.jsonviewboxis0 0 24 24Description