Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rust for Linux auto CI job #125209

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add Rust for Linux auto CI job #125209

wants to merge 8 commits into from

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 17, 2024

This PR adds an auto CI job that checks if Rust for Linux (RfL) still compiles with the latest version of the compiler and the standard library. If not, we should ideally ping the RfL ping group.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 17, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Kobzol Kobzol changed the title WIP: test Rust for Linux in PR CI Add Rust for Linux auto CI job May 21, 2024
@rust-log-analyzer

This comment has been minimized.

Copy link
Contributor

@ojeda ojeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this again! Some more comments/thoughts below...

I guess depending on how things go, i.e. how many failures we get and where they fail most, we could consider reducing or increasing the scope.

src/ci/docker/scripts/rfl-build.sh Outdated Show resolved Hide resolved
src/ci/docker/scripts/rfl-build.sh Outdated Show resolved Hide resolved
src/ci/github-actions/jobs.yml Outdated Show resolved Hide resolved
src/ci/docker/scripts/rfl-build.sh Show resolved Hide resolved
@Kobzol
Copy link
Contributor Author

Kobzol commented May 26, 2024

I think that the last thing required here is to select some reasonable initial commit. @ojeda any suggestions? I tried the commit that you have sent me before, but it was not found in the repo I think (maybe git just couldn't work with the shorter SHA though).

Is there any more up-to-date commit that I could use instead of master?

@ojeda
Copy link
Contributor

ojeda commented May 26, 2024

I tried the commit that you have sent me before, but it was not found in the repo I think (maybe git just couldn't work with the shorter SHA though).

The commit exists, but you probably need something like:

mkdir linux
git -C linux init
git -C linux remote add origin https://github.com/torvalds/linux.git
git -C linux fetch --depth 1 origin 8f5b5f78113e881cb8570c961b0dc42b218a1b9e
git -C linux checkout FETCH_HEAD

instead of --branch. Another way is using the archive URL, e.g. https://github.com/torvalds/linux/archive/8f5b5f78113e.tar.gz.

Also, later today Linus will likely tag v6.10-rc1, which we could also use.

@ojeda
Copy link
Contributor

ojeda commented May 26, 2024

Is there any more up-to-date commit that I could use instead of master?

Not sure what you mean, master is the latest in Linus' (and generally should not be used, since it will move). Do you mean something in the RFL repository?

@Kobzol
Copy link
Contributor Author

Kobzol commented May 26, 2024

Not sure what you mean, master is the latest in Linus' (and generally should not be used, since it will move). Do you mean something in the RFL repository?

Sorry, I meant "what is the most up-to-date commit SHA that works with RfL". master is not a stable ref, ofc.

@ojeda
Copy link
Contributor

ojeda commented May 26, 2024

Both should work (i.e. the one I gave you as well as the current master, i.e. c13320499ba0efd93174ef6462ae8a7a2933f6e7).

@ojeda
Copy link
Contributor

ojeda commented May 26, 2024

If you want to use the RFL repository as the base URL, I can push those commits there too.

@Kobzol
Copy link
Contributor Author

Kobzol commented May 26, 2024

No need for now, if it works with upstream Linux. I changed the commit SHA (thanks for the code to checkout a single commit!), let's see if everything still works.

@ojeda
Copy link
Contributor

ojeda commented May 26, 2024

My pleasure!

@Kobzol Kobzol marked this pull request as ready for review May 26, 2024 13:02
@Kobzol
Copy link
Contributor Author

Kobzol commented May 26, 2024

Ok, looks like it is working, this should be ready for a review now.

r? @Mark-Simulacrum

@rustbot ready

Successful CI run: https://github.com/rust-lang/rust/actions/runs/9243326050/job/25427322274?pr=125209 (~12 minutes on a 8 core CI runner).

Copy link
Member

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not an infra expert, but this patch LGMT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants