-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added safety_settings parameter for gemini #13568
Feature: Added safety_settings parameter for gemini #13568
Conversation
Feature Request : #10788 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. If you bump the version of the gemini llm integration package, it will auto publish on merge
I am a bit confused by the above wording, the change is in
Or in the gemini folder here |
Whoops, in the vertex package (for some reason I assumed this change was in the gemini package lol) |
7ece91c
to
b432080
Compare
Done, let me know if it looks good. |
llama-index-integrations/llms/llama-index-llms-vertex/llama_index/llms/vertex/base.py
Show resolved
Hide resolved
llama-index-integrations/llms/llama-index-llms-vertex/llama_index/llms/vertex/base.py
Outdated
Show resolved
Hide resolved
4a74679
to
cd25c1a
Compare
cd25c1a
to
424fd9f
Compare
Description
Currently, the Vertex API does not provide handling for safety_settings to Gemini. This update will enable users to configure safety_settings during the initialization of the Vertex module.
Vertex AI GenerativeMoel Reference : https://cloud.google.com/python/docs/reference/aiplatform/latest/vertexai.generative_models.GenerativeModel
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Have to confirm the right spot to update. Comment below.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Result: PASS
Suggested Checklist: