Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'exclude_llm_metadata_keys' and 'exclude_embed_metadata_keys' in Node Parsers #13567

Merged
merged 1 commit into from
May 20, 2024

Conversation

pratiksinghchauhan
Copy link
Contributor

Description

Pass 'exclude_llm_metadata_keys' and 'exclude_embed_metadata_keys' from Nodes to MarkdownElementNodeProcessor and UnstructuredElementNodeParser

Fixes #13468

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The code is manually tested on the case mentioned in the issue and other cases.

  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

…embed_metadata_keys' from Nodes to MarkdownElementNodeProcessor and UnstructuredElementNodeParser
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 17, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2024
@logan-markewich logan-markewich merged commit 993d609 into run-llama:main May 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
2 participants