Add more filter type in query for relyt vector database #13512
+291
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2024 19:12
dosubot
bot
added
the
size:L
| @@ -59,9 +59,10 @@ class RelytVectorStore(BasePydanticVectorStore): | |||
| _client: "PGVectoRs" = PrivateAttr() | |||
| _collection_name: str = PrivateAttr() | |||
|
|
|||
| def __init__(self, client: "PGVectoRs", collection_name: str) -> None: | |||
| def __init__(self, client: "PGVectoRs", collection_name: str, enable_vector_index: bool) -> None: | |||
There was a problem hiding this comment.
should this have a default option? Is there a reason to set this to false?
There was a problem hiding this comment.
okay, thanks review again, i will later to add more feature for this , when this pr ready , will invite you to review again
logan-markewich
approved these changes
May 22, 2024
|
@klaus-xiong small bump, can you update the example notebook and make sure it works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods