-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrations: upstage LLM and Embeddings #13193
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
llama-index-integrations/embeddings/llama-index-embeddings-upstage/README.md
Outdated
Show resolved
Hide resolved
...ntegrations/embeddings/llama-index-embeddings-upstage/llama_index/embeddings/upstage/base.py
Show resolved
Hide resolved
llama-index-integrations/embeddings/llama-index-embeddings-upstage/poetry.lock
Outdated
Show resolved
Hide resolved
llama-index-integrations/llms/llama-index-llms-upstage/README.md
Outdated
Show resolved
Hide resolved
llama-index-integrations/llms/llama-index-llms-upstage/poetry.lock
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, mostly just a few nits
I can't push to the repo, so I can't fix CICD 😓 But, to fit it
Then install pants Then run |
Thanks for detailed instruction. |
@logan-markewich tests failed. But when I test it it success. do i need something to do additionally?
|
Head branch was pushed to by a user without write access
@logan-markewich Would you check this action?, 3.10 passed but 3.8 and 3.9 were canceled because of long running tasks. |
Can you merge main again? There was some issues that were recently fixed |
2027623
to
38f0cb7
Compare
38f0cb7
to
00e803b
Compare
@logan-markewich action unit test failed with
I think I have pyproject set up correctly, all tests pass on my local as well, is there anything else I need to set up? |
@JuHyung-Son For the life of me I can't figure out why the embedding tests are failing. I've noticed that any class that inherits openai embeddings, pants (our cicd tool) does not properly detect dependencies. My advice is we can keep the tests (since they are nice for local dev), but we need to wrap the import in a try/except in the tests, and skip if not found |
Also just and fyi, the embeddings pyproject.toml is missing the |
Description
Upstage is one of the most up-and-coming LLM providers, and many of users want to use their LLM and Embeddings api, so in this PR, we've added an Upstage LLM and Embeddings integration.
Also we deprecated and added warning on solar LLM integration which will not be managed anymore.
Fixes #13192 (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods