Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Unify Support #12921

Merged
merged 28 commits into from
May 21, 2024
Merged

Add Unify Support #12921

merged 28 commits into from
May 21, 2024

Conversation

djl11
Copy link
Contributor

@djl11 djl11 commented Apr 18, 2024

Description

This PR adds a LLM integration package to support Unify AI. This includes dynamic routing across different endpoints and SSO for multiple providers.

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 18, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 19, 2024
@logan-markewich
Copy link
Collaborator

@djl11 looks like you need to run make lint for linting

I'd be happy to fix the CICD error myself, but I can't push to this PR.

To fix CICD, you'll need to

  • rm -f llama-index-integrations/llms/llama-index-llms-unify/BUILD
  • Install pants
  • Run pants tailor llama-index-integrations/llms/llama-index-llms-unify/::
  • commit any added/changed files

@logan-markewich
Copy link
Collaborator

@djl11 light bump on this

@hello-fri-end
Copy link
Contributor

Hey @logan-markewich, apologies for the super delayed response here. Everyone on the team has been extremely occupied with the launch due to which the PR slipped from our radar.

I have made all the fixes you requested. Please let me know if there's anything else you'd like me to add/change.

@logan-markewich
Copy link
Collaborator

Looks like you'd need to merge main, and also run make lint

@hello-fri-end
Copy link
Contributor

Looks like you'd need to merge main, and also run make lint

Fixed both! Hope there are no issues remaining now 🤞

@logan-markewich logan-markewich merged commit 74c00de into run-llama:main May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants