Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize row IDs hidden in Hadoop partitions #22775

Merged
merged 1 commit into from
May 20, 2024
Merged

Recognize row IDs hidden in Hadoop partitions #22775

merged 1 commit into from
May 20, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 17, 2024

Description

Hadoop partitions don't have a place for row ID partition components so store them inside the parameters as a string created by mapping the bytes to chars in ISO-8859-1.

Motivation and Context

Hive Partitions that were getting converted to and from org.apache.hadoop.hive.metastore.api.Partitions were losing the row ID partition component.

Impact

None

Test Plan

TestThriftHiveMetastoreUtil

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo marked this pull request as ready for review May 17, 2024 17:47
@elharo elharo requested a review from a team as a code owner May 17, 2024 17:47
@elharo elharo requested a review from presto-oss May 17, 2024 17:47
@rschlussel
Copy link
Contributor

actually, where is this used? Can we add this utility method when we add the usage too?

@elharo elharo merged commit e80152c into master May 20, 2024
56 checks passed
@elharo elharo deleted the hadoop branch May 20, 2024 20:15
@rschlussel
Copy link
Contributor

@elharo pointed out that the utility method is used to set the field in the partition right here in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants