Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull constant values out of loop and check earlier #22770

Merged
merged 1 commit into from
May 18, 2024
Merged

Pull constant values out of loop and check earlier #22770

merged 1 commit into from
May 18, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented May 16, 2024

Description

Pull constant values out of loop and check for $row_id earlier

Motivation and Context

Debugging weird failures in prod. Code works in some clusters and fails in others.

Impact

none

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@elharo elharo marked this pull request as ready for review May 17, 2024 11:30
@elharo elharo requested a review from a team as a code owner May 17, 2024 11:30
@elharo elharo requested a review from presto-oss May 17, 2024 11:30
Copy link
Collaborator

@sdruzkin sdruzkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elharo elharo merged commit c6ffb83 into master May 18, 2024
57 checks passed
@elharo elharo deleted the check branch May 18, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants