Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc: fix detecting kafka version (#11048) #11136

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11048

What problem does this PR solve?

Issue Number: close #11047

What is changed and how it works?

Expose requestVersion param and use the low version by default.
After getting version information, set kafka version as high as possible.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
  1. start cluster and Kafka (version=3.7.0)
  2. create a changefeed with kafka protocol
bin/cdc cli changefeed create -c test --sink-uri "kafka://127.0.0.1:9092/test?topic=test&protocol=open-protocol&max-message-bytes=41943040&compressionType=ZLIB&kafka-version=0.11.0.0"
  1. check CDC log
[WARN] [sarama.go:139] ["The Kafka version you assigned may not be correct. Please assign a version equal to or less than the specified version"] [assignedVersion=0.11.0.0] [desiredVersion=2.8.0]

note: The max Kafka version which sarama detects is v2.8.0.

kafka version status
3.7.0 success
3.0.1 success
2.8.0 success
2.7.0 success
2.5.0 success
2.4.0 success
2.3.1 success
2.1.1 success
2.1.0 success
2.0.1 success
2.0.0 success
1.0.1 success
0.11.0 success

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot added contribution Indicates that the PR was contributed by an external member. lgtm needs-ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels May 17, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. label May 17, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 17, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved The current cherry-pick pull request has not been approved and cannot be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2024
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 20, 2024
@CharlesCheung96
Copy link
Contributor

/test all

@CharlesCheung96 CharlesCheung96 self-assigned this May 21, 2024
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

4 similar comments
@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 126365e into pingcap:release-7.5 May 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. contribution Indicates that the PR was contributed by an external member. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants