-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mounter(ticdc): optimize mounter cpu usage by reduce memory allocation on map and slice #11081
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11081 +/- ##
================================================
- Coverage 57.6475% 57.6113% -0.0363%
================================================
Files 850 850
Lines 126040 126055 +15
================================================
- Hits 72659 72622 -37
- Misses 47985 48026 +41
- Partials 5396 5407 +11 |
Please add the test result. |
The metrics is lost, since I use continous profiling which delete metrics data each 3 hours. On the master branch, we can see obvious In this PR, the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
57b01d9
to
f59703a
Compare
What problem does this PR solve?
Issue Number: close #11210
What is changed and how it works?
sync.Pool
to reduce the map allocation for the datumcolumnInfo
slice from thedatums2Column
method, to reduce memory allocation.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note