Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP)kv(ticdc): print lock info and multi thread resolve lock #11069

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented May 10, 2024

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 10, 2024
Copy link
Contributor

ti-chi-bot bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sdojjy, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2024
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.3690%. Comparing base (ab0ce11) to head (3afce27).
Report is 3 commits behind head on master.

❗ Current head 3afce27 differs from pull request most recent head bf60945. Consider uploading reports for the commit bf60945 to get more accurate results

Additional details and impacted files
Components Coverage Δ
cdc 61.6257% <100.0000%> (+0.0336%) ⬆️
dm 51.2008% <ø> (-0.0122%) ⬇️
engine 63.4091% <ø> (+0.0070%) ⬆️
Flag Coverage Δ
unit 57.3690% <100.0000%> (+0.0122%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11069        +/-   ##
================================================
+ Coverage   57.3567%   57.3690%   +0.0122%     
================================================
  Files           851        851                
  Lines        125605     125606         +1     
================================================
+ Hits          72043      72059        +16     
+ Misses        48144      48131        -13     
+ Partials       5418       5416         -2     

Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

Copy link
Contributor

ti-chi-bot bot commented May 13, 2024

@sdojjy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test bf60945 link true /test cdc-integration-mysql-test
pull-cdc-integration-storage-test bf60945 link true /test cdc-integration-storage-test
pull-dm-compatibility-test bf60945 link true /test dm-compatibility-test
jenkins-ticdc/verify bf60945 link true /test verify
pull-cdc-integration-pulsar-test bf60945 link true /test cdc-integration-pulsar-test
pull-dm-integration-test bf60945 link true /test dm-integration-test
pull-cdc-integration-kafka-test bf60945 link true /test cdc-integration-kafka-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant