Fix including Debug CSS in the index template #4596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates the behavior when we were building the app with Gulp, in which the debug CSS was only included in local development.
To test:
frontend-watch
andfrontend-shadow
tabs to finish their jobs.2.
grep
fortext/css
in theresources/public/index.html
file. Two<link>
tags for CSS files should be included, one of them should bedebug.css
Ctrl+C
stop the jobs in thefrontend-watch
andfrontend-shadow
tabs.frontend
directory and build the app for production:cd frontend ./scripts/build
grep
that only a single CSS file is included in<link>
tags intarget/dist/index.html