src: fix execArgv in worker #53029
Merged
src: fix execArgv in worker #53029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
3 times, most recently
from
a5961c7
to
07b3e88
Compare
anonrig
approved these changes
May 16, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
from
07b3e88
to
c5fc44c
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
aduh95
reviewed
May 20, 2024
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
from
c5fc44c
to
41cfbf5
Compare
aduh95
approved these changes
May 20, 2024
theanarkh
force-pushed
the
fix_exec_argv_in_worker
branch
from
41cfbf5
to
79986bc
Compare
github-actions
bot
removed
the
request-ci
There was a problem hiding this comment.
Thanks for the fix!
In the future we can consider relaxing the check even more, to be "throw if there is any invalid execArgv that was not also an execArgv of the parent", so that these other test cases would pass:
// allow explicitly passing the default execArgv value
new Worker(CODE, { eval: true, execArgv: process.execArgv });
// run with the worker with the same config as the parent, except for --expose-internals
new Worker(CODE, { eval: true, execArgv: process.execArgv.filter(n => n !== "--expose-internals" });
theanarkh
added
the
author ready
aduh95
approved these changes
May 23, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c137d6e |
lukins-cz
pushed a commit
to lukins-cz/OS-Aplet-node
that referenced
this pull request
Jun 1, 2024
PR-URL: nodejs#53029 Fixes: nodejs#53011 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53011
make -j4 test(UNIX), orvcbuild test(Windows) passes