v18.20.3 proposal #53028

richardlau · 2024-05-16T16:21:27Z

2024-05-21, Version 18.20.3 'Hydrogen' (LTS), @richardlau

Notable Changes

This release fixes a regression introduced in Node.js 18.19.0 where http.server.close() was incorrectly closing idle connections.

A fix has also been included for compiling Node.js from source with newer versions of Clang.

The list of keys used to sign releases has been synchronized with the current list from the main branch.

Updated dependencies

acorn updated to 8.11.3.
acorn-walk updated to 8.3.2.
ada updated to 2.7.8.
c-ares updated to 1.28.1.
corepack updated to 0.28.0.
nghttp2 updated to 1.61.0.
ngtcp2 updated to 1.3.0.
npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections npm/cli#7324.
simdutf updated to 5.2.4.
zlib updated to 1.3.0.1-motley-7d77fb7.

Commits

[0c260e10e7] - deps: update zlib to 1.3.0.1-motley-7d77fb7 (Node.js GitHub Bot) #52516
[1152d7f919] - deps: update zlib to 1.3.0.1-motley-24c07df (Node.js GitHub Bot) #52199
[755399db9d] - deps: update zlib to 1.3.0.1-motley-24342f6 (Node.js GitHub Bot) #52123
[af3e32073b] - deps: update ada to 2.7.8 (Node.js GitHub Bot) #52517
[e4ea2db58b] - deps: update c-ares to 1.28.1 (Node.js GitHub Bot) #52285
[14e857bea2] - deps: update corepack to 0.28.0 (Node.js GitHub Bot) #52616
[7f5dd44ca6] - deps: upgrade npm to 10.7.0 (npm team) #52767
[78f84ebb09] - deps: update ngtcp2 to 1.3.0 (Node.js GitHub Bot) #51796
[1f489a3753] - deps: update ngtcp2 to 1.2.0 (Node.js GitHub Bot) #51584
[3034968225] - deps: update ngtcp2 to 1.1.0 (Node.js GitHub Bot) #51319
[1aa9da467f] - deps: add nghttp3/**/.deps to .gitignore (Luigi Pinca) #51400
[28c0c78c9a] - deps: update ngtcp2 and nghttp3 (James M Snell) #51291
[8fd5a35364] - deps: upgrade npm to 10.5.2 (npm team) #52458
[2c53ff31c9] - deps: update acorn-walk to 8.3.2 (Node.js GitHub Bot) #51457
[12f28f33c2] - deps: update acorn to 8.11.3 (Node.js GitHub Bot) #51317
[dddb7eb3e0] - deps: update acorn-walk to 8.3.1 (Node.js GitHub Bot) #50457
[c86550e607] - deps: update acorn-walk to 8.3.0 (Node.js GitHub Bot) #50457
[9500817f66] - deps: update acorn to 8.11.2 (Node.js GitHub Bot) #50460
[7a8c7b6275] - deps: update ada to 2.7.7 (Node.js GitHub Bot) #52028
[b199889943] - deps: update corepack to 0.26.0 (Node.js GitHub Bot) #52027
[052b0ba0c6] - deps: upgrade npm to 10.5.1 (npm team) #52351
[209823d3af] - deps: update simdutf to 5.2.4 (Node.js GitHub Bot) #52473
[5114cbe18a] - deps: update simdutf to 5.2.3 (Yagiz Nizipli) #52381
[be30309ea0] - deps: update simdutf to 5.0.0 (Daniel Lemire) #52138
[b56f66e250] - deps: update simdutf to 4.0.9 (Node.js GitHub Bot) #51655
[a9f3b9d9d1] - deps: update nghttp2 to 1.61.0 (Node.js GitHub Bot) #52395
[1b6fa70620] - deps: update nghttp2 to 1.60.0 (Node.js GitHub Bot) #51948
[3c9dbbf4d4] - deps: update nghttp2 to 1.59.0 (Node.js GitHub Bot) #51581
[e28316da54] - deps: update nghttp2 to 1.58.0 (Node.js GitHub Bot) #50441
[678641f470] - deps: V8: cherry-pick d15d49b09dc7 (Bo Anderson) #52337
[1147fee7d9] - doc: remove ableist language from crypto (Jamie King) #52063
[5e93eae972] - doc: add release key for marco-ippolito (marco-ippolito) #52257
[6689a98488] - http: remove closeIdleConnections function while calling server close (Kumar Rishav) #52336
[71616e8a8a] - node-api: make tsfn accept napi_finalize once more (Gabriel Schulhof) #51801
[d9d9e62474] - src: avoid draining platform tasks at FreeEnvironment (Chengzhong Wu) #51290
[e5fc8ec9fc] - test: skip v8-updates/test-linux-perf (Michaël Zasso) #49639
[351ef189ca] - test: v8: Add test-linux-perf-logger test suite (Luke Albao) #50352
[5cec2efc31] - test: reduce the number of requests and parsers (Luigi Pinca) #50240
[5186e453d9] - test: deflake test-http-regr-Segfault in node::Environment::KickNextTick #2928 (Luigi Pinca) #49574
[c60cd67e1c] - test: skip test for dynamically linked OpenSSL (Richard Lau) #52542

cc @nodejs/releasers

As a temporary measure to unblock the CI, skip the RSA implicit rejection test when Node.js is built against a dynamically linked OpenSSL. PR-URL: #52542 Refs: #52537 Refs: nodejs-private/node-private#525 Refs: https://hackerone.com/reports/2269177 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Original commit message: Make bitfields only as wide as necessary for enums clang now complains when a BitField for an enum is too wide. We could suppress this, but it seems kind of useful from an uninformed distance, so I made a few bitfields smaller instead. (For AddressingMode, since its size is target-dependent, I added an explicit underlying type to the enum instead, which suppresses the diag on a per-enum basis.) This is without any understanding of the code I'm touching. Especially the change in v8-internal.h feels a bit risky to me. Bug: chromium:1348574 Change-Id: I73395de593045036b72dadf4e3147b5f7e13c958 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3794708 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/main@{#82109} Refs: v8/v8@d15d49b PR-URL: #52337 Fixes: #52230 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Correcting the #50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. Fixes: #52330 Fixes: #51677 PR-URL: #52336 Refs: #50194 Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>

Hard code the value of the host parameter to `common.localhostIPv4` in `server.listen()` and `net.connect()`. This 1. ensures that the client `socket._handle` is not reinitialized during connection due to the family autodetection algorithm, preventing `parser.consume()` from being called with an invalid `socket._handle` parameter. 2. works around an issue in the FreeBSD 12 machine where the stress test is run where some sockets get stuck after connection. PR-URL: #49574 Backport-PR-URL: #52384 Closes: #49565 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>

The maximum number of parsers in the free list is set to 1000. However the test does not need to use this maximum. Reduce it to 50. Refs: #50228 (comment) PR-URL: #50240 Backport-PR-URL: #52384 Fixes: #49564 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>

PR-URL: #52257 Refs: nodejs/Release#984 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ruy Adorno <ruy@vlt.sh> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

PR-URL: #50441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #51581 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

PR-URL: #51948 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #52395 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #51655 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

PR-URL: #52138 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #52381 Refs: #51670 Reviewed-By: Daniel Lemire <daniel@lemire.me> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

PR-URL: #52473 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #52351 Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #52027 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #52028 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

PR-URL: #50460 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #51317 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: #51457 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>

The thread-safe function's finalizer is not called in conjunction with the garbage collection of a JS value. In fact, it keeps a strong reference to the JS function it is expected to call. Thus, it is safe to make calls that affect GC state from its body. PR-URL: #51801 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

PR-URL: #52458 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

PR-URL: #51400 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

PR-URL: #51319 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #51584 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #51796 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: #52767 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

mcollina · 2024-05-16T22:01:54Z

@legendecas could we include the FinalizationRegistry fix?

mcollina · 2024-05-16T22:03:55Z

This should be added if possible: #51290

At the point of `FreeEnvironment` and onwards, no JavaScript execution associated with the Environment should be triggered. Avoid draining platform tasks that can trigger JavaScript execution in `FreeEnvironment`. The holder of `node::Environment` should immediately call `node::MultiIsolatePlatform::UnregisterIsolate` and `v8::Isolate::Dispose` to cancel pending foreground tasks and join concurrent tasks after the environment was freed. `NodePlatform` can properly handle the case in `RunForegroundTask` when an Isolate out-lives its associated `node::Environment`. PR-URL: #51290 Fixes: #47748 Fixes: #49344 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: This release fixes a regression introduced in Node.js 18.19.0 where `http.server.close()` was incorrectly closing idle connections. A fix has also been included for compiling Node.js from source with newer versions of Clang. The list of keys used to sign releases has been synchronized with the current list from the `main` branch. Updated dependencies: - acorn updated to 8.11.3. - acorn-walk updated to 8.3.2. - ada updated to 2.7.8. - c-ares updated to 1.28.1. - corepack updated to 0.28.0. - nghttp2 updated to 1.61.0. - ngtcp2 updated to 1.3.0. - npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections. - simdutf updated to 5.2.4. - zlib updated to 1.3.0.1-motley-7d77fb7. PR-URL: #53028

legendecas · 2024-05-16T22:53:42Z

@mcollina yeah, I can verify the problem can be reproduced on v18.x, and #51290 clean lands on the staging branch and fixes the problem.

richardlau · 2024-05-16T22:55:03Z

@mcollina yeah, I can verify the problem can be reproduced on v18.x, and #51290 clean lands on the staging branch and fixes the problem.

I've already cherry-picked it 🙂.

nodejs-github-bot · 2024-05-17T01:16:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59260/
V8-CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/5983/

CITGM:
Previous release (v18.20.2): https://ci.nodejs.org/job/citgm-smoker/3431/
This release: https://ci.nodejs.org/job/citgm-smoker/3433/

mcollina

lgtm

richardlau · 2024-05-17T13:41:51Z

$ ncu-ci citgm 3431 3433
--------------------------------------------------------------------------------
[1/1] Running CITGM: 3431
--------------------------------------------------------------------------------
✔  Summary data downloaded
✔  Results data downloaded
✔  Summary data downloaded
✔  Results data downloaded
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/3431/
Source     https://api.github.com/repos/nodejs/node/git/refs/tags/v18.20.2
Commit     [9aedf16f8fb3] 2024-04-10, Version 18.20.2 'Hydrogen' (LTS)
Date       2024-04-10 09:12:07 -0300
Author     Rafael Gonzaga <rafael.nunu@hotmail.com>
----------------------------------- Summary ------------------------------------
Result     FAILURE
URL        https://ci.nodejs.org/job/citgm-smoker/3433/
Source     https://api.github.com/repos/nodejs/node/git/refs/heads/v18.20.3-proposal
Commit     [64903b1ca04d] 2024-05-21, Version 18.20.3 'Hydrogen' (LTS)
Date       2024-05-16 22:36:39 +0000
Author     Richard Lau <rlau@redhat.com>
----------------------------------- Results ------------------------------------



FAILURE: 5 failures in 3433 not present in 3431


┌────────────────────────┬───────────────────┬───────────────┐
│ (index)                │ 0                 │ 1             │
├────────────────────────┼───────────────────┼───────────────┤
│ alpine-last-latest-x64 │ 'pino-v9.1.0'     │               │
│ fedora-last-latest-x64 │                   │               │
│ debian11-x64           │ 'undici-v6.16.1'  │               │
│ rhel8-ppc64le          │ 'fastify-v4.27.0' │ 'tape-v5.7.5' │
│ ubuntu2204-64          │                   │               │
│ debian12-x64           │                   │               │
│ rhel8-x64              │                   │               │
│ aix72-ppc64            │                   │               │
│ rhel8-s390x            │ 'undici-v6.16.1'  │               │
│ fedora-latest-x64      │                   │               │
│ alpine-latest-x64      │                   │               │
└────────────────────────┴───────────────────┴───────────────┘

While that's not a lot of "new" failures, for undici-v6.16.1 Node.js 18.20.3 appears to be encountering a HeadersOverflowError on Linux:
e.g. https://ci.nodejs.org/job/citgm-smoker/3433/nodes=debian11-x64/testReport/junit/(root)/citgm/undici_v6_16_1/

  Content-Length is set when using a FormData body with fetch (3544.837845ms)
 /home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:12862
       Error.captureStackTrace(err, this);
             ^
 TypeError: fetch failed
     at /home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:12862:13 {
   [cause]: HeadersOverflowError: Headers Overflow Error
       at Parser.trackHeader (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5749:37)
       at Parser.onHeaderField (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5723:14)
       at wasm_on_header_field (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5539:34)
       at wasm://wasm/0002f80e:wasm-function[41]:0x84cb
       at wasm://wasm/0002f80e:wasm-function[20]:0x605b
       at Parser.execute (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5665:26)
       at Parser.readMore (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5644:16)
       at TLSSocket.<anonymous> (/home/iojs/tmp/citgm_tmp/6ba972b9-9a01-41bc-bdcf-2022f809a1ae/undici/undici-fetch.js:5972:18)
       at TLSSocket.emit (node:events:517:28)
       at emitReadable_ (node:internal/streams/readable:633:12) {
     code: 'UND_ERR_HEADERS_OVERFLOW'
   }
 }
 Node.js v18.20.3

Also

(most of these don't show up in the comparison table because they failed with 18.20.2 for other reasons)

I can recreate this on my local Linux development machine (with undici 16.17.0, which I guess has just been released).
In current nodejs/citgm checkout:
Passes:

nvm run 18.20.2 bin/citgm undici

Fails:

cd /home/rlau/sandbox/github/trees/v18.x
configure --verbose && make -j 88
python3 tools/install.py install '' /home/rlau/sandbox/testnode
cd /home/rlau/sandbox/github/citgm
PATH=/home/rlau/sandbox/testnode/bin/:$PATH node bin/citgm undici

richardlau · 2024-05-17T14:40:03Z

Bisecting points to #52336, which is meant to fix a regression (#51677 and #52330). @nodejs/undici thoughts?

mcollina · 2024-05-17T17:25:50Z

We would need to investigate this. Fastify uses Undici internally, so I guess those things are connected.

@ronag @ShogunPanda could you take a look as well?

metcoder95 · 2024-05-19T11:33:35Z

Just to verify, I've been trying to isolate the issue and it seems is not strictly related to the one shared ([cause]: HeadersOverflowError: Headers Overflow Error), as that one its kind of expected and the tests passes ( is the result of an execSync).

For undici, the bisect lead me to what it seems the faulty: test/fetch/fetch-leak.js. It seems just a matter of closing the idle connections to make the test pass

ShogunPanda · 2024-05-20T11:45:02Z

I agree with @metcoder95.
In the test he mentioned the failure was to to an t.after never completing as the HTTP server was not closed before the interval ran again.
If you swap the order of the t.after in that file the test would pass.
Anyway, to avoid differences between runtimes, I proposed a different patch, see: nodejs/undici#3279 (this patch also hides the misleading headers overflow output).

I think this failures are not related to node and thus we can proceed with this release.

richardlau · 2024-05-20T12:34:33Z

I think this failures are not related to node and thus we can proceed with this release.

👍 Thanks @metcoder95 and @ShogunPanda for looking at this. I'll proceed with the release as planned tomorrow.

mcollina · 2024-05-20T13:00:31Z

undici v6.18 is out, with a fix if you want to try again.

richardlau · 2024-05-20T23:39:12Z

Release CI with 64903b1: https://ci-release.nodejs.org/job/iojs+release/10213/
Rebuild of platforms which failed to upload to the staging server (rhel8-arm64-release, rhel8-ppc64le-release and rhel8-s390x-release): https://ci-release.nodejs.org/job/iojs+release/10214/

PR-URL: #53028

Notable changes: This release fixes a regression introduced in Node.js 18.19.0 where `http.server.close()` was incorrectly closing idle connections. A fix has also been included for compiling Node.js from source with newer versions of Clang. The list of keys used to sign releases has been synchronized with the current list from the `main` branch. Updated dependencies: - acorn updated to 8.11.3. - acorn-walk updated to 8.3.2. - ada updated to 2.7.8. - c-ares updated to 1.28.1. - corepack updated to 0.28.0. - nghttp2 updated to 1.61.0. - ngtcp2 updated to 1.3.0. - npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections. - simdutf updated to 5.2.4. - zlib updated to 1.3.0.1-motley-7d77fb7. PR-URL: #53028

Refs: nodejs/node#53028

Notable changes: This release fixes a regression introduced in Node.js 18.19.0 where `http.server.close()` was incorrectly closing idle connections. A fix has also been included for compiling Node.js from source with newer versions of Clang. The list of keys used to sign releases has been synchronized with the current list from the `main` branch. Updated dependencies: - acorn updated to 8.11.3. - acorn-walk updated to 8.3.2. - ada updated to 2.7.8. - c-ares updated to 1.28.1. - corepack updated to 0.28.0. - nghttp2 updated to 1.61.0. - ngtcp2 updated to 1.3.0. - npm updated to 10.7.0. Includes a fix from npm@10.5.1 to limit the number of open connections. - simdutf updated to 5.2.4. - zlib updated to 1.3.0.1-motley-7d77fb7. PR-URL: nodejs#53028

richardlau and others added 30 commits April 17, 2024 11:58

deps: update nghttp2 to 1.58.0

e28316d

PR-URL: #50441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

deps: update nghttp2 to 1.59.0

3c9dbbf

PR-URL: #51581 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

deps: update nghttp2 to 1.60.0

1b6fa70

PR-URL: #51948 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

deps: update simdutf to 4.0.9

b56f66e

PR-URL: #51655 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

deps: update simdutf to 5.0.0

be30309

PR-URL: #52138 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

deps: update simdutf to 5.2.4

209823d

PR-URL: #52473 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

deps: update acorn to 8.11.2

9500817

PR-URL: #50460 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

deps: update acorn-walk to 8.3.0

c86550e

PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

deps: update acorn-walk to 8.3.1

dddb7eb

PR-URL: #50457 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

deps: update acorn to 8.11.3

12f28f3

PR-URL: #51317 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

deps: update acorn-walk to 8.3.2

2c53ff3

PR-URL: #51457 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>

deps: upgrade npm to 10.5.2

8fd5a35

PR-URL: #52458 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>

deps: update ngtcp2 and nghttp3

28c0c78

PR-URL: #51291 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

deps: add nghttp3/**/.deps to .gitignore

1aa9da4

PR-URL: #51400 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

deps: update ngtcp2 to 1.1.0

3034968

PR-URL: #51319 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

deps: update ngtcp2 to 1.2.0

1f489a3

PR-URL: #51584 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

deps: update ngtcp2 to 1.3.0

78f84eb

PR-URL: #51796 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

deps: upgrade npm to 10.7.0

7f5dd44

PR-URL: #52767 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

legendecas and others added 2 commits May 16, 2024 22:20

richardlau force-pushed the v18.20.3-proposal branch from 192fe4a to 64903b1 Compare May 16, 2024 22:37

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024

This comment was marked as outdated.

Sign in to view

mcollina approved these changes May 17, 2024

View reviewed changes

ShogunPanda mentioned this pull request May 20, 2024

fix: Fix server closing in tests. nodejs/undici#3279

Merged

7 tasks

richardlau merged commit 64903b1 into v18.x May 21, 2024
55 checks passed

richardlau deleted the v18.20.3-proposal branch May 21, 2024 11:54

richardlau added a commit that referenced this pull request May 21, 2024

Working on v18.20.4

dc9eed9

PR-URL: #53028

richardlau added a commit to nodejs/nodejs.org that referenced this pull request May 21, 2024

Blog: v18.20.3 release post

c82bedf

Refs: nodejs/node#53028

richardlau mentioned this pull request May 21, 2024

Blog: v18.20.3 release post nodejs/nodejs.org#6730

Merged

5 tasks

github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 21, 2024

Blog: v18.20.3 release post (#6730)

876c5e2

Refs: nodejs/node#53028

github-merge-queue bot pushed a commit to nodejs/nodejs.org that referenced this pull request May 21, 2024

Blog: v18.20.3 release post (#6730)

9ad9238

Refs: nodejs/node#53028

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v18.20.3 proposal #53028

v18.20.3 proposal #53028

richardlau commented May 16, 2024 •

edited

mcollina commented May 16, 2024

mcollina commented May 16, 2024

This comment was marked as outdated.

legendecas commented May 16, 2024

richardlau commented May 16, 2024

nodejs-github-bot commented May 17, 2024 •

edited by richardlau

mcollina left a comment

richardlau commented May 17, 2024 •

edited

richardlau commented May 17, 2024

mcollina commented May 17, 2024

metcoder95 commented May 19, 2024

ShogunPanda commented May 20, 2024

richardlau commented May 20, 2024

mcollina commented May 20, 2024

richardlau commented May 20, 2024 •

edited

v18.20.3 proposal #53028

v18.20.3 proposal #53028

Conversation

richardlau commented May 16, 2024 • edited

2024-05-21, Version 18.20.3 'Hydrogen' (LTS), @richardlau

Notable Changes

Updated dependencies

Commits

mcollina commented May 16, 2024

mcollina commented May 16, 2024

This comment was marked as outdated.

legendecas commented May 16, 2024

richardlau commented May 16, 2024

nodejs-github-bot commented May 17, 2024 • edited by richardlau

mcollina left a comment

Choose a reason for hiding this comment

richardlau commented May 17, 2024 • edited

richardlau commented May 17, 2024

mcollina commented May 17, 2024

metcoder95 commented May 19, 2024

ShogunPanda commented May 20, 2024

richardlau commented May 20, 2024

mcollina commented May 20, 2024

richardlau commented May 20, 2024 • edited

richardlau commented May 16, 2024 •

edited

nodejs-github-bot commented May 17, 2024 •

edited by richardlau

richardlau commented May 17, 2024 •

edited

richardlau commented May 20, 2024 •

edited