Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: support lint-md-fix #53024

Closed
wants to merge 3 commits into from
Closed

build: support lint-md-fix #53024

wants to merge 3 commits into from

Conversation

RedYetiDev
Copy link
Member

Similar to lint-js-fix, this PR adds submit for lint-md-fix, which supplies the --fix CLI argument to the Markdown linter.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 16, 2024
@RedYetiDev
Copy link
Member Author

@nodejs/linting
@nodejs/build-files

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 16, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59248/

@lpinca
Copy link
Member

lpinca commented May 16, 2024 •
edited

Can you also add it to vcbuild.bat?

Nvm, lint-js-fix is also not supported with vcbuild.bat.

@RedYetiDev
Copy link
Member Author

Can you also add it to vcbuild.bat?

Nvm, lint-js-fix is also not supported with vcbuild.bat.

Once this lands, I can try to open a second PR to add them both (if it is possible)

@marco-ippolito marco-ippolito added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 17, 2024
@RedYetiDev RedYetiDev mentioned this pull request May 18, 2024
Open
@RedYetiDev
Copy link
Member Author

So, I feel pretty stupid right now 😆 the markdown linter doesn't support a --fix flag, I must be crazy, because I could've sworn it did.

@RedYetiDev RedYetiDev closed this May 21, 2024
@RedYetiDev RedYetiDev deleted the patch-30 branch May 21, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@MoLow MoLow MoLow approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@RedYetiDev @nodejs-github-bot @lpinca @benjamingr @tniessen @MoLow @marco-ippolito