Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix ClangCL ARM64 cross-compilation #53003

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

StefanStojanovic
Copy link
Contributor

This PR is a WIP for fixing the ClangCL cross-compilation to ARM64. It consists of 2 dependency updates that should be done upstream and 1 change in Node.js itself to make everything work:

A fix in ICU a6932ad - To increase the chances of this landing upstream, the change is done by adding an option for this use case so it doesn't break any previously experienced behavior. After this is reviewed and discussed, I plan to open a PR in the ICU and try to land it there.

A fix in FP16 f8b52b5 - This already landed in the base repo. Since that project is a dependency of the V8, a CL to update it in V8 will be opened.

Node.js changes 176f1c6 - Once everything else is done, the change in the main repo is a simple one.

NOTE: Depending on the affected upstream projects and their release cycles and updates, we may need to use the patches on our side for some time.

cc @targos @lemire @nodejs/i18n-api

Refs: #52809

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels May 15, 2024
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StefanStojanovic

After this is reviewed and discussed, I plan to open a PR in the ICU and try to land it there.

hi! Please file a ticket (or see ICU-21633 and linked tickets) and PR to ICU first. I'm -1 on innovating here, it's just going to get dropped the next time through. This PR modifies a generated file, which is ignored under some contexts.

Depending on the affected upstream projects and their release cycles and updates, we may need to use the patches on our side for some time

I sent you a note on Slack on that topic. If there does need to be a patch, I'd rather it was a backport of a PR actually landed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file. i18n-api Issues and PRs related to the i18n implementation. icu Issues and PRs related to the ICU dependency. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants