New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: allow `--test-[name/skip]-pattern` in `NODE_OPTIONS` #53001

Open

RedYetiDev wants to merge 2 commits into nodejs:main from RedYetiDev:patch-29

Member

RedYetiDev commented May 15, 2024 •

edited

workaround for #51384

NODE_OPTIONS="--test-name-pattern=XXX" node my_test.js

Allows --test-name-pattern and --test-skip-pattern to appear in the NODE_OPTIONS environment variable.


          cli: allow --test-[name/skip]-pattern in NODE_OPTIONS

628df79

nodejs-github-bot added c++ needs-ci labels

RedYetiDev added cli test_runner labels


          doc: add arguments to NODE_OPTIONS (cli.md)

ae26ffb

Contributor

cjihrig commented May 15, 2024

Just an FYI - this does not fix #51384.

Member Author

RedYetiDev commented May 15, 2024

Just an FYI - this does not fix #51384.

Why? If these options can be passed as env variables, then they won't be hostile to NPM scripts, as they can be used in the variable? Right?

Contributor

cjihrig commented May 15, 2024

The ask in that issue is to be able to run something like npm test -- --test-name-pattern="my pattern". More generally (based on feedback I've received), people want to be able to mix test runner arguments in process.execArgv and process.argv.

I'm not saying this is a bad change, but this is not what is being requested and I don't think people will be satisfied with it for that use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment