Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lsp): add textDocument/documentLink to capability map #28838

Merged
merged 1 commit into from
May 21, 2024
Merged

fix(lsp): add textDocument/documentLink to capability map #28838

merged 1 commit into from
May 21, 2024

Conversation

icholy
Copy link
Contributor

@icholy icholy commented May 18, 2024

The supports_method method returns true if it doesn't recognize the LSP method. As a result, the following request is sent to clients that don't support it:

local params = { textDocument = util.make_text_document_params() }
vim.lsp.buf_request(0, "textDocument/documentLink", params, function(err, result, ctx)
    // ...
end)

@github-actions github-actions bot added the lsp label May 18, 2024
@icholy icholy changed the title feat(lsp): teach supports_method about textDocument/documentLink fix(lsp): teach supports_method about textDocument/documentLink May 18, 2024
@MariaSolOs
Copy link
Member

I think a more appropriate PR title/commit message would be fix(lsp): add textDocument/documentLink to capability map.

@icholy
Copy link
Contributor Author

icholy commented May 19, 2024

updated

@icholy icholy changed the title fix(lsp): teach supports_method about textDocument/documentLink fix(lsp): add textDocument/documentLink to capability map May 19, 2024
@mfussenegger mfussenegger merged commit 8263ed4 into neovim:master May 21, 2024
29 checks passed
@github-actions github-actions bot removed the request for review from mfussenegger May 21, 2024 16:17
github-actions bot pushed a commit that referenced this pull request May 21, 2024
@icholy @github-actions
fix(lsp): add textDocument/documentLink to capability map (#28838)
e8ecc4f 
(cherry picked from commit 8263ed4)
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-0.10:

@github-actions github-actions bot mentioned this pull request May 21, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

Git push to origin failed for release-0.10 with exitcode 1

mfussenegger pushed a commit that referenced this pull request May 21, 2024
@icholy @mfussenegger
fix(lsp): add textDocument/documentLink to capability map (#28838)
4f0c4c3 
(cherry picked from commit 8263ed4)
huangyingw pushed a commit to huangyingw/neovim that referenced this pull request May 31, 2024
@icholy @huangyingw
fix(lsp): add textDocument/documentLink to capability map (neovim#28838)
fef55eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaSolOs MariaSolOs MariaSolOs approved these changes

Assignees
No one assigned
Labels
ci:backport release-0.10 lsp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icholy @MariaSolOs @mfussenegger