[codemod] Add codemod for removing system props #42282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-42282--material-ui.netlify.app/ Bundle size report |
DiegoAndai
approved these changes
May 23, 2024
| } | ||
|
|
||
| describe('@mui/codemod', () => { | ||
| describe('v6.0.0 - removeSystemProps', () => { |
There was a problem hiding this comment.
DiegoAndai
reviewed
May 24, 2024
There was a problem hiding this comment.
I've approved but noticed that we didn't add deprecation warnings for the props, may I ask you to do that @siriwatknp? That way we can close #42259
It's also valid to do it in a different PR, let me know if you prefer that instead
Thanks for pointing out, I am about to do that in a separate one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with the core repo, and everything looks good.