-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][TableSortLabel] Deprecate composed classes #42281
base: next
Are you sure you want to change the base?
Conversation
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
@@ -26,6 +34,8 @@ const tableSortLabelClasses: TableSortLabelClasses = generateUtilityClasses('Mui | |||
'icon', | |||
'iconDirectionDesc', | |||
'iconDirectionAsc', | |||
'directionDesc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new classes
}); | ||
|
||
it('when given direction asc should have asc direction class', () => { | ||
const { container } = render(<TableSortLabel direction="asc" />); | ||
const icon = container.querySelector(`.${classes.icon}`); | ||
expect(icon).not.to.have.class(classes.iconDirectionDesc); | ||
expect(icon).to.have.class(classes.iconDirectionAsc); | ||
expect(container.firstChild).to.have.class(classes.directionAsc); | ||
expect(container.querySelector(`.${classes.directionAsc} > .${classes.icon}`)).not.equal( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to make sure replacement selector is actually working
Not sure about argos failure, don't think they are related to this PR |
part of #41282