-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add QC check and report for ClinGen labels #7244
base: master
Are you sure you want to change the base?
Conversation
@matentzn This looks good to me, but it appears that the QC fails because the new QC test works. I guess we need to wait for ClinGen to review the list we shared with them when we met (Wed, Feb 7th). |
Yes, they need to provide fixes for the 26 conflicts.. |
@sabrinatoro can you follow up with ClinGen when they plan to supply the fixes? |
@twhetzel I assigned this PR to you as you voiced interest in manually fixing the 25 clingen conflicts. |
Without tickets/PRs on the latest Mondo release board, it's longer before I see these. Is there still something to be done here or is any work in this PR now included in #6903? |
The thing that needs to be done on this PR is to fix the QC, i.e. fixing the ClinGen preferred labels. I thought you mentioned you were going to do this because there are few? See #7630 |
make some changes to kickoff the qc checks again since logs expired
Adding my Slack comment here: For example, the error line for: |
@sabrinatoro found out during curation that there are some Mondo terms with multiple ClinGen labels. We already know from #7027 that there were times when ClinGen labels made it into the curation pipeline which where not exact.
This PR