-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend OMIM check to look for ancestors rather than only direct parents #6466
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the rdfs:subClassOf+
returned the direct and indirect subclasses vs. ancestors mentioned in the PR title, but I gather this is the change you want to make so approving.
@twhetzel I have now assigned this PR to @sabrinatoro for triage, as there is quite a bit of manual curation involved into fixing it. @sabrinatoro you let us know if you need help with this! As a reminder, this is the implementation of the following proposition: We do not want to have one OMIM turn subclass of another OMIM term unless this is specifically reviewed and approved. Before this PR, we only checked cases where the direct parent of an OMIM disease was an OMIM disease. This PR increases the severity of this checking by checking cases where an OMIM disease has an ancestor that is an OMIM disease. |
@@ -11,7 +11,7 @@ prefix mondoSparqlQcMondo: <http://purl.obolibrary.org/obo/mondo/sparql/qc/mondo | |||
prefix mondoPatterns: <http://purl.obolibrary.org/obo/mondo/patterns/> | |||
|
|||
SELECT DISTINCT ?entity ?property ?value WHERE { | |||
?entity rdfs:subClassOf ?parent . | |||
?entity rdfs:subClassOf+ ?parent . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nico said:
This PR increases the severity of this checking by checking cases where an OMIM disease has an ancestor that is an OMIM disease.
LGTM!
No description provided.