perf: improve regexp performance by using non-capturing groups #58551

antfu · 2024-05-16T15:22:00Z

This PR is a performance improvement to TS cli/compiler for RegExps of file path matching. Currently, it uses dynamically constructed regex with groups to match multiple path patterns. While all RegExp groups are capturing, but we only use regex.test(file) function, which doesn't consume those groups at all.

I am building a RegExp monitor regex-doctor and found those regexes are taking quite some time to do the matches, even in a very small project. I imagine the cost of running those regexes could scale up with the package size.

For example, in my testing repo, this regex cost a total 8.48ms to match against 17 paths (and crates a RegexMatchArray with 233 unconsumed groups in this case)

After this PR, the time cost to match with the exact same inputs becomes 3.36ms (60% faster on regex matching).

Can you help to initiate the bot to run a proper benchmark and see how it would help the overall performance? Thanks.

typescript-bot · 2024-05-16T15:22:04Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jakebailey · 2024-05-16T16:08:35Z

Funnily I was already about to send a PR similar to this one using the findings from https://www.npmjs.com/package/eslint-plugin-regexp.

@typescript-bot test it

typescript-bot · 2024-05-16T16:08:38Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

jakebailey · 2024-05-16T16:09:17Z

Actually, this PR is perpendicular as it affects dynamically created regexes. Very nice!

typescript-bot · 2024-05-16T16:29:26Z

@jakebailey Here are the results of running the user tests comparing main and refs/pull/58551/merge:

Everything looks good!

typescript-bot · 2024-05-16T16:32:59Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-05-16T16:51:16Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,154	_62,154	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,248	_50,248	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,485k (± 0.96%)}	_{193,449k (± 0.97%)}	_~	_192,199k	_195,880k	_{p=0.378 n=6}
_{Parse Time}	_{1.55s (± 1.62%)}	_{1.55s (± 1.98%)}	_~	_1.51s	_1.58s	_{p=0.745 n=6}
_{Bind Time}	_{0.86s (± 0.63%)}	_{0.87s (± 0.94%)}	_~	_0.86s	_0.88s	_{p=0.859 n=6}
_{Check Time}	_{11.31s (± 0.36%)}	_{11.34s (± 0.24%)}	_~	_11.32s	_11.39s	_{p=0.172 n=6}
_{Emit Time}	_{3.15s (± 0.43%)}	_{3.14s (± 0.79%)}	_~	_3.09s	_3.16s	_{p=0.934 n=6}
_{Total Time}	_{16.87s (± 0.24%)}	_{16.90s (± 0.17%)}	_~	_16.86s	_16.94s	_{p=0.198 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,110	_944,110	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,140	_407,140	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,113k (± 0.00%)}	_{1,222,105k (± 0.00%)}	_~	_1,222,016k	_1,222,148k	_{p=0.936 n=6}
_{Parse Time}	_{6.77s (± 0.40%)}	_{6.79s (± 0.65%)}	_~	_6.73s	_6.84s	_{p=0.467 n=6}
_{Bind Time}	_{1.88s (± 0.58%)}	_{1.87s (± 0.52%)}	_~	_1.86s	_1.89s	_{p=0.143 n=6}
_{Check Time}	_{31.24s (± 0.52%)}	_{31.31s (± 0.28%)}	_~	_31.23s	_31.43s	_{p=0.423 n=6}
_{Emit Time}	_{14.71s (± 0.31%)}	_{14.71s (± 0.68%)}	_~	_14.58s	_14.84s	_{p=0.748 n=6}
_{Total Time}	_{54.59s (± 0.32%)}	_{54.69s (± 0.29%)}	_~	_54.43s	_54.92s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,964,178	_1,964,178	_~	_~	_~	_{p=1.000 n=6}
_Types	_819,287	_819,287	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,849,617k (± 0.00%)}	_{1,849,640k (± 0.00%)}	_~	_1,849,605k	_1,849,691k	_{p=0.378 n=6}
_{Parse Time}	_{6.78s (± 0.49%)}	_{6.78s (± 0.28%)}	_~	_6.76s	_6.81s	_{p=0.808 n=6}
_{Bind Time}	_{2.29s (± 0.55%)}	_{2.30s (± 1.39%)}	_~	_2.27s	_2.36s	_{p=0.858 n=6}
_{Check Time}	_{58.56s (± 0.37%)}	_{58.92s (± 0.40%)}	_{+0.36s (+ 0.62%)}	_58.72s	_59.37s	_{p=0.031 n=6}
_{Emit Time}	_0.14s	_{0.14s (± 2.88%)}	_~	_0.14s	_0.15s	_{p=0.405 n=6}
_{Total Time}	_{67.77s (± 0.29%)}	_{68.13s (± 0.34%)}	_{+0.37s (+ 0.54%)}	_67.96s	_68.57s	_{p=0.031 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,231	_1,221,231	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,523	_259,525	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,337,530k (± 0.02%)}	_{2,362,787k (± 2.59%)}	_~	_2,336,844k	_2,487,867k	_{p=0.378 n=6}
_{Parse Time}	_{5.00s (± 1.14%)}	_{5.00s (± 0.90%)}	_~	_4.95s	_5.05s	_{p=0.810 n=6}
_{Bind Time}	_{1.88s (± 0.75%)}	_{1.88s (± 0.43%)}	_~	_1.87s	_1.89s	_{p=0.677 n=6}
_{Check Time}	_{33.78s (± 0.24%)}	_{33.80s (± 0.29%)}	_~	_33.66s	_33.91s	_{p=0.630 n=6}
_{Emit Time}	_{2.65s (± 1.60%)}	_{2.62s (± 2.99%)}	_~	_2.53s	_2.71s	_{p=0.748 n=6}
_{Total Time}	_{43.31s (± 0.34%)}	_{43.33s (± 0.37%)}	_~	_43.06s	_43.50s	_{p=0.748 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,221,231	_1,221,231	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,523	_259,525	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,413,565k (± 0.02%)}	_{2,413,646k (± 0.04%)}	_~	_2,412,411k	_2,414,535k	_{p=0.689 n=6}
_{Parse Time}	_{6.19s (± 0.79%)}	_{6.18s (± 1.14%)}	_~	_6.12s	_6.28s	_{p=0.575 n=6}
_{Bind Time}	_{2.00s (± 0.93%)}	_{2.03s (± 0.52%)}	_{+0.02s (+ 1.00%)}	_2.01s	_2.04s	_{p=0.040 n=6}
_{Check Time}	_{40.16s (± 0.25%)}	_{40.11s (± 0.34%)}	_~	_39.88s	_40.25s	_{p=0.521 n=6}
_{Emit Time}	_{3.11s (± 3.37%)}	_{3.12s (± 2.92%)}	_~	_3.00s	_3.26s	_{p=0.748 n=6}
_{Total Time}	_{51.48s (± 0.34%)}	_{51.46s (± 0.36%)}	_~	_51.22s	_51.73s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_256,768	_256,768	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,587	_104,589	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{426,072k (± 0.01%)}	_{426,066k (± 0.01%)}	_~	_426,037k	_426,122k	_{p=0.810 n=6}
_{Parse Time}	_{2.79s (± 0.42%)}	_{2.79s (± 0.43%)}	_~	_2.78s	_2.81s	_{p=0.388 n=6}
_{Bind Time}	_{1.11s (± 0.74%)}	_{1.10s (± 0.74%)}	_~	_1.09s	_1.11s	_{p=0.389 n=6}
_{Check Time}	_{15.20s (± 0.49%)}	_{15.18s (± 0.44%)}	_~	_15.07s	_15.26s	_{p=0.747 n=6}
_{Emit Time}	_{1.15s (± 0.85%)}	_{1.15s (± 1.28%)}	_~	_1.13s	_1.17s	_{p=0.615 n=6}
_{Total Time}	_{20.25s (± 0.37%)}	_{20.22s (± 0.35%)}	_~	_20.11s	_20.30s	_{p=0.747 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,575	_224,575	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,785	_93,785	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,862k (± 0.03%)}	_{369,852k (± 0.03%)}	_~	_369,696k	_369,972k	_{p=0.810 n=6}
_{Parse Time}	_{3.53s (± 1.00%)}	_{3.51s (± 0.68%)}	_~	_3.48s	_3.55s	_{p=0.466 n=6}
_{Bind Time}	_{1.93s (± 0.71%)}	_{1.92s (± 1.52%)}	_~	_1.87s	_1.95s	_{p=0.560 n=6}
_{Check Time}	_{19.40s (± 0.26%)}	_{19.34s (± 0.19%)}	_~	_19.28s	_19.39s	_{p=0.053 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.86s (± 0.28%)}	_{24.77s (± 0.26%)}	_{-0.09s (- 0.38%)}	_24.66s	_24.84s	_{p=0.045 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,823,415	_2,823,415	_~	_~	_~	_{p=1.000 n=6}
_Types	_957,881	_957,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,996,465k (± 0.00%)}	_{2,996,475k (± 0.00%)}	_~	_2,996,422k	_2,996,537k	_{p=0.936 n=6}
_{Parse Time}	_{17.05s (± 0.27%)}	_{17.03s (± 0.43%)}	_~	_16.94s	_17.16s	_{p=0.470 n=6}
_{Bind Time}	_{5.05s (± 0.35%)}	_{5.05s (± 0.41%)}	_~	_5.02s	_5.08s	_{p=0.681 n=6}
_{Check Time}	_{89.23s (± 0.19%)}	_{89.99s (± 2.25%)}	_~	_88.90s	_94.11s	_{p=1.000 n=6}
_{Emit Time}	_{28.86s (± 0.59%)}	_{28.03s (± 6.48%)}	_~	_24.32s	_28.88s	_{p=0.336 n=6}
_{Total Time}	_{140.19s (± 0.12%)}	_{140.09s (± 0.24%)}	_~	_139.65s	_140.50s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_265,866	_265,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,401	_108,401	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{410,578k (± 0.03%)}	_{410,488k (± 0.01%)}	_~	_410,426k	_410,528k	_{p=0.128 n=6}
_{Parse Time}	_{3.84s (± 1.07%)}	_{3.83s (± 0.96%)}	_~	_3.79s	_3.87s	_{p=1.000 n=6}
_{Bind Time}	_{1.67s (± 0.90%)}	_{1.66s (± 1.28%)}	_~	_1.63s	_1.69s	_{p=0.326 n=6}
_{Check Time}	_{17.00s (± 0.55%)}	_{16.91s (± 0.23%)}	_~	_16.86s	_16.97s	_{p=0.109 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.51s (± 0.39%)}	_{22.41s (± 0.30%)}	_~	_22.34s	_22.49s	_{p=0.108 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_524,639	_524,639	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,906	_178,906	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{462,703k (± 0.02%)}	_{462,732k (± 0.01%)}	_~	_462,667k	_462,837k	_{p=0.689 n=6}
_{Parse Time}	_{3.88s (± 0.55%)}	_{3.88s (± 0.47%)}	_~	_3.87s	_3.91s	_{p=0.676 n=6}
_{Bind Time}	_{1.44s (± 0.57%)}	_{1.45s (± 1.94%)}	_~	_1.41s	_1.47s	_{p=1.000 n=6}
_{Check Time}	_{22.44s (± 0.81%)}	_{22.47s (± 0.70%)}	_~	_22.26s	_22.73s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.76s (± 0.66%)}	_{27.80s (± 0.48%)}	_~	_27.60s	_28.02s	_{p=0.520 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-05-16T16:51:42Z

Perf looks unaffected, I'm afraid.

typescript-bot · 2024-05-16T17:53:04Z

@jakebailey Here are the results of running the top 400 repos comparing main and refs/pull/58551/merge:

Everything looks good!

antfu added 2 commits May 16, 2024 17:01

perf: improve regexp performance by using non-capturing groups

0cc32bd

fix: one more

721cd5d

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: improve regexp performance by using non-capturing groups #58551

perf: improve regexp performance by using non-capturing groups #58551

antfu commented May 16, 2024 •

edited

typescript-bot commented May 16, 2024

jakebailey commented May 16, 2024

typescript-bot commented May 16, 2024 •

edited

jakebailey commented May 16, 2024

typescript-bot commented May 16, 2024

typescript-bot commented May 16, 2024

typescript-bot commented May 16, 2024

tsc

jakebailey commented May 16, 2024

typescript-bot commented May 16, 2024

perf: improve regexp performance by using non-capturing groups #58551

Are you sure you want to change the base?

perf: improve regexp performance by using non-capturing groups #58551

Conversation

antfu commented May 16, 2024 • edited

typescript-bot commented May 16, 2024

jakebailey commented May 16, 2024

typescript-bot commented May 16, 2024 • edited

jakebailey commented May 16, 2024

typescript-bot commented May 16, 2024

typescript-bot commented May 16, 2024

typescript-bot commented May 16, 2024

tsc

jakebailey commented May 16, 2024

typescript-bot commented May 16, 2024

antfu commented May 16, 2024 •

edited

typescript-bot commented May 16, 2024 •

edited