move to code actions update and tests

[justschen]

Fixes ##58387

as discussed in the sync, we added the additional check to implicit and also mirrored the fixes from move to file for move to new file.

a lot of tests were added (if excessive we can delete), and fixes to move to new file were added but also understand that move to new file will likely be deprecated anyways eventually.

---

regarding changing:

TypeScript/tests/cases/fourslash/moveToNewFile_prologueDirectives4.ts

Line 8 in 5c21b7f

verify.moveToNewFile({

since getApplicableRefactors defaults to implicit:

TypeScript/src/harness/fourslashImpl.ts

Line 4454 in 5c21b7f

private getApplicableRefactors(rangeOrMarker: Range | Marker, preferences = ts.emptyOptions, triggerReason: ts.RefactorTriggerReason = "implicit", kind?: string, includeInteractiveActions?: boolean): readonly ts.ApplicableRefactorInfo[] {

the test was changed to have no refactorings (to match our proposed case).

---

regarding implicit vs invoked:

Check for implicit to follow our idea for manual requested in vs code vs. not manually requested in vs code, but let me know if our logic here makes sense!

cc. @aiday-mar @mjbvz

[justschen]

update @aiday-mar, looks like triggerReason gets passed all the way from typescript extension:

https://github.com/microsoft/vscode/blob/cdf94536b9dafc36582d2ecfd246897c6feb7d72/extensions/typescript-language-features/src/languageFeatures/refactor.ts#L551

private toTsTriggerReason(context: vscode.CodeActionContext): Proto.RefactorTriggerReason | undefined {
	return context.triggerKind === vscode.CodeActionTriggerKind.Invoke ? 'invoked' : 'implicit';
}

which gets propagated thru CodeActionTriggerKind between automatic and invoke which we set in the model 👍

[aiday-mar]

Looks good, thanks!

[justschen]

cc. @andrewbranch @navya9singh @DanielRosenwasser (realized i never pinged or mentioned you guys on this 😨)

[andrewbranch]

Thanks!

[justschen]

@andrewbranch @navya9singh awesome thanks guys! feel free to merge when ready (I'm not authorized here 🔢 )