-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2% vaccinated budget. #935
base: main
Are you sure you want to change the base?
Conversation
Also should we change the default budget to 2% (if we're doing that in the blog post?) |
✅ Deploy Preview for microcov ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I don't think 2% should be the default budget because "vaccinated" isn't
the default status. We could link them, but that seems like trouble to me.
…On Wed, Aug 4, 2021 at 10:20 AM Jeremy Blanchard ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/components/calculator/PointsDisplay.tsx
<#935 (comment)>:
> - if (name === 'dangerously-high')
- return t('calculator.category_dangerously_high')
- if (name === 'extreme') return t('calculator.category_extreme')
+ if (name === 'dangerously-high' || name === 'extreme')
+ return t('calculator.category_extreme')
I think you maybe have this backward? Dangerously high is below extreme.
Here's how they each look:
[image: image]
<https://user-images.githubusercontent.com/32290/128225647-a69a23f9-c532-4cca-a61e-4c55cf3293e8.png>
[image: image]
<https://user-images.githubusercontent.com/32290/128225674-f1c23830-512f-468e-8435-d3577769aa18.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#935 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM25LPC2ENAAZ2HKBGPCPLT3FZF5ANCNFSM5BRSXXPQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
@beshaya did we decide we aren't doing this and that it's just a personal choice? or...? |
Also remove "dangerously high risk" and use "extremely" instead.
I appreciate the change here - guiding users toward selecting a higher risk tolerance based on vaccination. I found myself trying to communicate this factor outside the site and would be grateful to have some accounting for the reasonably increased tolerance for infection due to reduced severity and other treatments afforded by developments. |
src/locales/en.json
Outdated
"category_very_high": "Very High", | ||
"category_dangerously_high": "Dangerously high", | ||
"category_extreme": "Extremely High", | ||
"category_postfix": "Risk", | ||
"location_risk_message": "<1>~{{ prevalence }} of people here are currently infectious.</1> We use this number to estimate the baseline chance of transmission per person nearby (given no further information about their behavior).", | ||
"location_sublabel": { | ||
"CA": "Province/territory", | ||
"US": "County", | ||
"US-AK": "Borough", | ||
"US-LA": "Parish", | ||
"country_or_regions": "Region" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"country_or_regions": "Region" | |
"country_or_regions": "Region" | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I messed up the merge; fixed in 87bd4d2.
Codecov Report
@@ Coverage Diff @@
## main #935 +/- ##
==========================================
+ Coverage 66.24% 66.26% +0.02%
==========================================
Files 104 104
Lines 2829 2831 +2
Branches 514 514
==========================================
+ Hits 1874 1876 +2
Misses 804 804
Partials 151 151
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Also remove "dangerously high risk" and use "extremely" instead.