Use official docker images for Postgres/Mongo #42870
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `circleci/*` images were deprecated in late 2021 and replaced by `cimg/*` images. But I think we can just use the official images.
johnswanson
added
the
backport
iethree
reviewed
May 20, 2024
| @@ -735,7 +735,7 @@ jobs: | |||
| MB_POSTGRES_SSL_TEST_SSL_ROOT_CERT_PATH: 'test-resources/certificates/us-east-2-bundle.pem' | |||
| services: | |||
| postgres: | |||
| image: circleci/postgres:latest | |||
| image: postgres:latest | |||
There was a problem hiding this comment.
probably a question for @metabase/core-backend-qp , but do we want to use :latest? I would suspect we should pin to a known-supported tag and re-evaluate periodically?
There was a problem hiding this comment.
I've updated mysql to the :latest version In the PR #36025. As there were no objections from the rest of the team, I believe that approach is ok.
lbrdnk
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
circleci/*images were deprecated in late 2021 and replaced bycimg/*images. But I think we can just use the official images.