Preserve FK key metadata on native models #42866
Merged
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #42130. This PR assumes that the only way a native model can have columns with FK semantic types is if a user specified it by editing the metadata.
|
ranquild
reviewed
May 17, 2024
| db (t2/select-one Database :id database_id) | ||
| ;; a native model can have columns with keys as semantic types on if a user specified it | ||
| trust-semantic-keys? (and (= (:type card) :model) | ||
| (= (-> card :dataset_query :type) :native))] |
There was a problem hiding this comment.
A regular (mbql) model can also have metadata overrides with FKs for columns that are not FKs in the DB
There was a problem hiding this comment.
@ranquild Do you have an example when that information gets lost? (The FK override on mbql models worked for me.)
There was a problem hiding this comment.
I don't have an example. I think you're right and that's the fix we need to do. It should be safe to "trust" FK metadata on native queries because it won't be set automatically.
There was a problem hiding this comment.
I've just noticed the typo in the comment. I meant "only if a user specified it", not "on if a user specified it".
ranquild
approved these changes
May 20, 2024
ranquild
added
backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42130.
This PR assumes that the only way a native model can have columns with FK semantic types is if a user specified it by editing the metadata.
TODO