Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak appearance of cache page and form #42856

Merged
merged 4 commits into from
May 28, 2024
Merged

Tweak appearance of cache page and form #42856

merged 4 commits into from
May 28, 2024

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 17, 2024

Fixes these issues with the cache page and form:

  • Use "Clear cache", not "Invalidate"
  • There was too much distance between the DB icon and the name of the DB
  • Constrain max width of strategy editor
  • Fix padding on form in sidebar and on Admin page
  • On Admin/Performance, make each big rectangle in the left panel clickable (not just the button on the right side of that rectangle)

Loom going over the changes: https://www.loom.com/share/7db77bdc251548bdb93b22101f692147?sid=62e788fe-61a6-4417-9d3d-2f98f18f6431

Closes #42958

Copy link
Contributor Author

rafpaf commented May 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 17, 2024
@rafpaf rafpaf changed the title Fix font size of subtitles Tweaks to appearance of cache page and form May 17, 2024
@rafpaf rafpaf added the backport Automatically create PR on current release branch on merge label May 20, 2024
@rafpaf rafpaf added this to the 0.50 milestone May 20, 2024
@rafpaf rafpaf requested a review from mazameli May 20, 2024 19:13
@rafpaf rafpaf marked this pull request as ready for review May 20, 2024 19:49
@graphite-app graphite-app bot added the no-backport Do not backport this PR to any branch label May 20, 2024
@graphite-app graphite-app bot requested a review from a team May 20, 2024 19:50
Copy link

graphite-app bot commented May 20, 2024

Graphite Automations

"Don't backport" took an action on this PR • (05/20/24)

1 reviewer was added and 1 label was added to this PR based on Raphael Krut-Landau's automation.

"Notify author when CI fails" took an action on this PR • (05/20/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

"Warn authors when publishing large PRs" took an action on this PR • (05/24/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

Copy link

replay-io bot commented May 20, 2024

Status In Progress ↗︎ 55 / 56
Commit 48d7908
Results
⚠️ 2 Flaky
2569 Passed

Copy link
Contributor

@mazameli mazameli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Only thing that it would be great to tweak is that we should make hovering on the big rectangles on the left also trigger the :hover state for the element (making the pill blue and the text white) so that it's clearer that it's a clickable, interactive element.

@rafpaf rafpaf removed this from the 0.50 milestone May 21, 2024
@rafpaf rafpaf changed the title Tweaks to appearance of cache page and form Tweak appearance of cache page and form May 21, 2024
@rafpaf rafpaf mentioned this pull request May 21, 2024
@iethree iethree self-requested a review May 21, 2024 22:54
Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

  • Please don't use styles= prop.
  • There's a few places where the styling will be much more maintainable if we use fewer styling conventions at once

Copy link
Contributor

@iethree iethree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@rafpaf rafpaf added this to the 0.50 milestone May 28, 2024
@rafpaf rafpaf enabled auto-merge (squash) May 28, 2024 18:34
@rafpaf rafpaf dismissed mazameli’s stale review May 28, 2024 21:30

maz approved via slack

@rafpaf rafpaf merged commit b9d037f into master May 28, 2024
111 checks passed
@rafpaf rafpaf deleted the perf/tweaks branch May 28, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak appearance of cache page and form
3 participants