Allow charts font override in SDK #42855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniskaber
added
embedding-sdk-build
|
heypoom
approved these changes
May 20, 2024
I checked it with local setup. Found one small issue when font is not defined in the client app config, fixed. Merging now |
deniskaber
added a commit
that referenced
this pull request
May 22, 2024
* Allow charts font override in SDK * Fix default not configured font (cherry picked from commit 0278b8d)
Merged
deniskaber
added a commit
that referenced
this pull request
May 22, 2024
* Restore default styles for subtle button (#42854) * fix(sdk): Use theme font in charts and tooltips (#42855) * Allow charts font override in SDK * Fix default not configured font (cherry picked from commit 0278b8d) * fix(sdk): Various fixes for InteractiveQuestion theming (#42932) * Fixes for InteractiveQuestion theming * Update readme * Fix for unset filter theme color * Fix unit tests * Fix unit tests (cherry picked from commit a3c3193) # Conflicts: # enterprise/frontend/src/embedding-sdk/lib/theme/embedding-color-palette.ts # enterprise/frontend/src/embedding-sdk/lib/theme/get-embedding-theme.ts # frontend/src/metabase/ui/utils/colors.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42341
Description
This makes selected font applied to charts and tooltips in Embedding SDK
How to verify
Describe the steps to verify that the changes are working as expected.
Demo
Upload a demo video or before/after screenshots if sensible or remove the section
Checklist