Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics V2] Adjust expression clauses in metric refs #42847

Closed
wants to merge 2 commits into from
Closed

[Metrics V2] Adjust expression clauses in metric refs #42847

wants to merge 2 commits into from
+60 −31

Conversation

snoe
Copy link
Contributor

@snoe snoe commented May 17, 2024

Fixes #42360

@snoe snoe added the .Team/QueryProcessor :hammer_and_wrench: label May 17, 2024
@snoe snoe requested a review from a team May 17, 2024 17:51
@snoe snoe self-assigned this May 17, 2024
@snoe snoe requested a review from camsaul as a code owner May 17, 2024 17:51
@replay-io replay.io
Copy link

replay-io bot commented May 17, 2024 •
edited

Status In Progress ↗︎ 53 / 54
Commit da48d58
Results
❌ 1 Failed
⚠️ 3 Flaky
✅ 2564 Passed

metamben
metamben approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@metamben metamben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perivamsi perivamsi deleted the branch metrics-v2 May 21, 2024 15:51
@perivamsi perivamsi closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metamben metamben metamben approved these changes

@camsaul camsaul Awaiting requested review from camsaul

Assignees

@snoe snoe

Labels
.Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@snoe @metamben @perivamsi