feat(sdk): apply user interface color overrides to the sdk #42834
+162
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heypoom
commented
May 17, 2024
enterprise/frontend/src/metabase-enterprise/whitelabel/lib/whitelabel.js
Outdated
Show resolved
Hide resolved
heypoom
force-pushed
the
sdk-apply-ui-color-overrides
branch
from
63ff183
to
ad91607
Compare
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff fca30b1...c8f39d2. No notifications. |
|
heypoom
commented
May 20, 2024
Comment on lines
+18
to
+21
| export const SdkThemeProvider = ({ theme, children }: Props) => { | ||
| const appColors = useSelector(state => | ||
| getApplicationColors(getSettings(state)), | ||
| ); |
There was a problem hiding this comment.
The extra component is needed because of the provider structure, the call to useSelector needs to be below ReduxProvider but above ThemeProvider
selector state set global embedding colors rename the method
heypoom
force-pushed
the
sdk-apply-ui-color-overrides
branch
from
57d8a05
to
41e996b
Compare
|
(Waiting for the offset e2e fix by the QC folks to be merged - #42944) |
oisincoveney
pushed a commit
that referenced
this pull request
May 21, 2024
* feat(sdk): apply ui color overrides to the sdk selector state set global embedding colors rename the method * test(sdk): add unit test on color overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42705
Description
Applies the user interface colors in the enterprise appearance settings as the SDK's default value.
How to verify
test-sdk-colorsbranch in the demo appAppProvider.tsx, and ensure that everything incolorsare commented outbrandcolor in the SDK, the sdk color should now take precedence.Caveat
Demo
Checklist