Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent chrome crash in cypress when input has auto-focus #42818

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

uladzimirdev
Copy link
Contributor

Important

For those employed by Metabase: if you are merging into master, please add either a backport or a no-backport label
to this PR. You will not be able to merge until you do this step. Refer to the section Do I need to backport this
PR?

in the Metabase Branching Strategy document for more details. If you're not employed by Metabase, this section does not
apply to you, and the label will be taken care of by your reviewer.

Warning

If that is your first contribution to Metabase, please sign the Contributor License Agreement (unless it's a tiny documentation change). Also, if you're attempting to fix a translation issue, please submit your changes to our POEditor project instead of opening a PR.

Closes https://github.com/metabase/metabase/issues/[issue_number]

Description

Describe the overall approach and the problem being solved.

How to verify

Describe the steps to verify that the changes are working as expected.

  1. New question -> Sample Dataset -> ...
  2. ...

Demo

Upload a demo video or before/after screenshots if sensible or remove the section

Checklist

  • Tests have been added/updated to cover changes in this PR

Copy link

github-actions bot commented May 17, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff fca30b1...79adc82.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/visualizations/Heading/Heading.tsx
frontend/src/metabase/visualizations/visualizations/Heading/Heading.unit.spec.tsx
frontend/src/metabase/visualizations/visualizations/Text/Text.jsx
frontend/src/metabase/visualizations/visualizations/Text/Text.unit.spec.tsx

Copy link

replay-io bot commented May 17, 2024

Status Complete ↗︎
Commit 79adc82
Results
⚠️ 1 Flaky
2568 Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant