Fixing a couple Recents API corner cases #42813
Merged
+231
−179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove def wtf - uncomment + fix tests
|
- official is a string - ensure the database for a recent table exists
escherize
changed the title
escherize
commented
May 20, 2024
escherize
commented
May 20, 2024
- This seems like something that should never happen, but I've seen it happen. I think it might be possible from a down/up migration.
noahmoss
approved these changes
May 20, 2024
- improve recent view testing for table
|
@escherize Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
oisincoveney
pushed a commit
that referenced
this pull request
May 22, 2024
* handle visibilty_type on tables - remove def wtf - uncomment + fix tests * make sure parent colls exist on report_cards - official is a string - ensure the database for a recent table exists * remove def + improve arg name * docstring * improve + extract valid parent collection check * grab the entity's colllection id and use that for the validity test - This seems like something that should never happen, but I've seen it happen. I think it might be possible from a down/up migration. * fix tests * fix more tests * cleanup * fixing another test * add error-avoider, to filter bad items in prod instead of throwing - improve recent view testing for table * remove wrap (it double prints the value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't really rely on some app db constraints, so I am filtering out invalid recent view items for entities that are e.g. missing parent collections.